Add an async ReadBody method to QuicChromiumClientStream::Handle

Add an async ReadBody method to QuicChromiumClientStream::Handle

This does not change OnClose or OnError and the callback is not yet invoked
on errors. That will happen after all the upcalls are replaced by async
methods.

BUG=716563
Review-Url: https://codereview.chromium.org/2877063002
Cr-Commit-Position: refs/heads/master@{#475172}
Committed: https://chromium.googlesource.com/chromium/src/+/27da045892e94846096a6549a178b34ee4d8f9d3

[Ryan Hamilton, 2017-05-12 13:27:26]

rch@chromium.org changed reviewers:
+ xunjieli@chromium.org

[xunjieli, 2017-05-12 15:22:22]

lgtm mod four nits below. The new interface looks much more user-friendly! nice
work.

https://codereview.chromium.org/2877063002/diff/1/net/quic/chromium/bidirecti...
File net/quic/chromium/bidirectional_stream_quic_impl.cc (right):

https://codereview.chromium.org/2877063002/diff/1/net/quic/chromium/bidirecti...
net/quic/chromium/bidirectional_stream_quic_impl.cc:121: // called upon
completion.
nit: Could you remove this old comment (line 120 to 121)? 
I think the new API is much easier to understand, so the comment is no longer
needed.

https://codereview.chromium.org/2877063002/diff/1/net/quic/chromium/quic_chro...
File net/quic/chromium/quic_chromium_client_stream.cc (right):

https://codereview.chromium.org/2877063002/diff/1/net/quic/chromium/quic_chro...
net/quic/chromium/quic_chromium_client_stream.cc:26: : stream_(stream),
delegate_(delegate), read_headers_buffer_(nullptr) {
nit: need to default initialize |read_body_buffer_len_|

https://codereview.chromium.org/2877063002/diff/1/net/quic/chromium/quic_chro...
File net/quic/chromium/quic_chromium_client_stream_test.cc (right):

https://codereview.chromium.org/2877063002/diff/1/net/quic/chromium/quic_chro...
net/quic/chromium/quic_chromium_client_stream_test.cc:413:
TEST_P(QuicChromiumClientStreamTest, OnDataAvailableEarly) {
Why is this testing OnDataAvailable Early?
The OnStreamFrame happens after handle_->ReadBody(), right?
Should this be OnDataAvailableLate or OnDataAvailableAfterReadBody?

https://codereview.chromium.org/2877063002/diff/1/net/quic/chromium/quic_http...
File net/quic/chromium/quic_http_stream.cc (left):

https://codereview.chromium.org/2877063002/diff/1/net/quic/chromium/quic_http...
net/quic/chromium/quic_http_stream.cc:777:
UMA_HISTOGRAM_BOOLEAN("Net.QuicReadAvailableData.NullStream", null_stream);
Could you mark this histogram as deprecated in histograms.xml?

[Ryan Hamilton, 2017-05-12 17:26:24]

Thanks!

https://codereview.chromium.org/2877063002/diff/1/net/quic/chromium/bidirecti...
File net/quic/chromium/bidirectional_stream_quic_impl.cc (right):

https://codereview.chromium.org/2877063002/diff/1/net/quic/chromium/bidirecti...
net/quic/chromium/bidirectional_stream_quic_impl.cc:121: // called upon
completion.
On 2017/05/12 15:22:22, xunjieli wrote:
> nit: Could you remove this old comment (line 120 to 121)? 
> I think the new API is much easier to understand, so the comment is no longer
> needed.

Great! Done.

https://codereview.chromium.org/2877063002/diff/1/net/quic/chromium/quic_chro...
File net/quic/chromium/quic_chromium_client_stream.cc (right):

https://codereview.chromium.org/2877063002/diff/1/net/quic/chromium/quic_chro...
net/quic/chromium/quic_chromium_client_stream.cc:26: : stream_(stream),
delegate_(delegate), read_headers_buffer_(nullptr) {
On 2017/05/12 15:22:22, xunjieli wrote:
> nit: need to default initialize |read_body_buffer_len_|

Done.

https://codereview.chromium.org/2877063002/diff/1/net/quic/chromium/quic_chro...
File net/quic/chromium/quic_chromium_client_stream_test.cc (right):

https://codereview.chromium.org/2877063002/diff/1/net/quic/chromium/quic_chro...
net/quic/chromium/quic_chromium_client_stream_test.cc:413:
TEST_P(QuicChromiumClientStreamTest, OnDataAvailableEarly) {
On 2017/05/12 15:22:22, xunjieli wrote:
> Why is this testing OnDataAvailable Early?
> The OnStreamFrame happens after handle_->ReadBody(), right?
> Should this be OnDataAvailableLate or OnDataAvailableAfterReadBody?

Good point. Done.

[xunjieli, 2017-05-12 17:29:20]

Thanks. still lgtm

[Ryan Hamilton, 2017-05-26 13:17:34]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2017-05-26 13:17:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/2877063002/#ps80001
(title: "Call OnFinRead from async read completion")

[commit-bot: I haz the power, 2017-05-26 13:17:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 13:25:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 13:25:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ryan Hamilton, 2017-05-26 13:59:56]

rch@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2017-05-26 14:56:24]

lgtm

[Ryan Hamilton, 2017-05-26 16:20:01]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2017-05-26 16:20:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/2877063002/#ps100001
(title: "format")

[commit-bot: I haz the power, 2017-05-26 16:20:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 17:51:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 17:51:05]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Ryan Hamilton, 2017-05-26 22:04:39]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2017-05-26 22:05:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 22:54:58]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495836279200530,
"parent_rev": "0fd268c608f2d2967c81b1deb1b521848ce2039a", "commit_rev":
"27da045892e94846096a6549a178b34ee4d8f9d3"}

[commit-bot: I haz the power, 2017-05-26 22:55:06]

Description was changed from

==========
Add an async ReadBody method to QuicChromiumClientStream::Handle

This does not change OnClose or OnError and the callback is not yet invoked
on errors. That will happen after all the upcalls are replaced by async
methods.

BUG=716563
==========

to

==========
Add an async ReadBody method to QuicChromiumClientStream::Handle

This does not change OnClose or OnError and the callback is not yet invoked
on errors. That will happen after all the upcalls are replaced by async
methods.

BUG=716563

Review-Url: https://codereview.chromium.org/2877063002
Cr-Commit-Position: refs/heads/master@{#475172}
Committed:
https://chromium.googlesource.com/chromium/src/+/27da045892e94846096a6549a178...
==========

[commit-bot: I haz the power, 2017-05-26 22:55:07]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/27da045892e94846096a6549a178...