Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2877003002: (Android) Fix Bluetooth keyboard focus issues in settings (Closed)

Created:
3 years, 7 months ago by mcdavid
Modified:
3 years, 6 months ago
Reviewers:
Daniel Park, Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org, injae
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

(Android) Fix Bluetooth keyboard focus issues in settings A couple of the widgets in the settings menu (text scaling slider, clear data timespan dropdown, learn more link) were not accessible via bluetooth keyboard. This change allows those items to receive focus within the containing ListView. BUG=674736 Review-Url: https://codereview.chromium.org/2877003002 Cr-Commit-Position: refs/heads/master@{#471183} Committed: https://chromium.googlesource.com/chromium/src/+/410c20c087bed3fa610e8442d7b90b8b5729a155

Patch Set 1 #

Patch Set 2 : Android: Only allow focus on JS AlertDialog messages with enough text to scroll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java View 1 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java View 1 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mcdavid
Hi Theresa, This patch fixes a few more issues with bluetooth keyboards in the settings ...
3 years, 7 months ago (2017-05-11 23:56:15 UTC) #3
Theresa
lgtm
3 years, 7 months ago (2017-05-12 00:39:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877003002/1
3 years, 7 months ago (2017-05-12 00:44:18 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 02:07:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/410c20c087bed3fa610e8442d7b9...

Powered by Google App Engine
This is Rietveld 408576698