arc: Stabilize ARC Icon test

arc: Stabilize ARC Icon test

This fixes icon test flaky and does tests more strict.

TEST=Unit tests
BUG=628425
Review-Url: https://codereview.chromium.org/2876993004
Cr-Commit-Position: refs/heads/master@{#472007}
Committed: https://chromium.googlesource.com/chromium/src/+/7e7ed9921f134e1e48aec31509e7195f7150deb8

[khmel, 2017-05-13 00:23:22]

The CQ bit was checked by khmel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-13 00:23:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 00:38:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 00:38:30]

Dry run: This issue passed the CQ dry run.

[khmel, 2017-05-15 16:28:56]

khmel@chromium.org changed reviewers:
+ xiyuan@chromium.org

[khmel, 2017-05-15 16:28:57]

Hi Xiyuan, PTAL (not urgent), Thanks

[xiyuan, 2017-05-15 18:27:13]

lgtm

https://codereview.chromium.org/2876993004/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_unittest.cc (right):

https://codereview.chromium.org/2876993004/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_unittest.cc:106: void
WaitForIconCreated(ArcAppListPrefs* prefs,
nit: WaitForIconCreated -> WaitForIconCreation

[khmel, 2017-05-16 02:03:26]

Thank you!

https://codereview.chromium.org/2876993004/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_unittest.cc (right):

https://codereview.chromium.org/2876993004/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_unittest.cc:106: void
WaitForIconCreated(ArcAppListPrefs* prefs,
On 2017/05/15 18:27:13, xiyuan wrote:
> nit: WaitForIconCreated -> WaitForIconCreation

Done.

[khmel, 2017-05-16 02:03:29]

The CQ bit was checked by khmel@chromium.org

[khmel, 2017-05-16 02:03:29]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2876993004/#ps10001
(title: "nit")

[commit-bot: I haz the power, 2017-05-16 02:04:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 02:09:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:09:48]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[khmel, 2017-05-16 02:14:43]

The CQ bit was checked by khmel@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:15:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 02:19:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:19:42]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[khmel, 2017-05-16 03:40:19]

The CQ bit was checked by khmel@chromium.org

[commit-bot: I haz the power, 2017-05-16 03:40:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 03:54:51]

CQ is committing da patch.

Bot data: {"patchset_id": 10001, "attempt_start_ts": 1494906019424590,
"parent_rev": "35c9b9467e191901889c235cfc438fd32a99edf6", "commit_rev":
"7e7ed9921f134e1e48aec31509e7195f7150deb8"}

[commit-bot: I haz the power, 2017-05-16 03:55:04]

Description was changed from

==========
arc: Stabilize ARC Icon test

This fixes icon test flaky and does tests more strict.

TEST=Unit tests
BUG=628425
==========

to

==========
arc: Stabilize ARC Icon test

This fixes icon test flaky and does tests more strict.

TEST=Unit tests
BUG=628425

Review-Url: https://codereview.chromium.org/2876993004
Cr-Commit-Position: refs/heads/master@{#472007}
Committed:
https://chromium.googlesource.com/chromium/src/+/7e7ed9921f134e1e48aec31509e7...
==========

[commit-bot: I haz the power, 2017-05-16 03:55:05]

Committed patchset #2 (id:10001) as
https://chromium.googlesource.com/chromium/src/+/7e7ed9921f134e1e48aec31509e7...