Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1946)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2876973003: Rename *Focus*-methods of FrameSelection to clarify its public API (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameSelection.h
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h
index 3d54e701caca6adf6ac37fff239ec0552ce43090..b8cdb5e144ec881929f4958ea4ae9947a6bd7472 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.h
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h
@@ -204,10 +204,9 @@ class CORE_EXPORT FrameSelection final
// Focus
bool SelectionHasFocus() const;
- // TODO(hugoh): Rename the following 3 methods to:
- void SetFocused(bool); // SetFrameIsFocused(),
- bool IsFocused() const { return focused_; } // FrameIsFocused(),
- bool IsFocusedAndActive() const; // FrameIsFocusedAndActive().
+ void SetFrameIsFocused(bool);
+ bool FrameIsFocused() const { return focused_; }
+ bool FrameIsFocusedAndActive() const;
void PageActivationChanged();
void SetUseSecureKeyboardEntryWhenActive(bool);
« no previous file with comments | « third_party/WebKit/Source/core/css/SelectorChecker.cpp ('k') | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698