Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2876973003: Rename *Focus*-methods of FrameSelection to clarify its public API (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 void InvalidatePaint(const LayoutBlock&, const PaintInvalidatorContext&); 197 void InvalidatePaint(const LayoutBlock&, const PaintInvalidatorContext&);
198 198
199 void PaintCaret(GraphicsContext&, const LayoutPoint&); 199 void PaintCaret(GraphicsContext&, const LayoutPoint&);
200 200
201 // Used to suspend caret blinking while the mouse is down. 201 // Used to suspend caret blinking while the mouse is down.
202 void SetCaretBlinkingSuspended(bool); 202 void SetCaretBlinkingSuspended(bool);
203 bool IsCaretBlinkingSuspended() const; 203 bool IsCaretBlinkingSuspended() const;
204 204
205 // Focus 205 // Focus
206 bool SelectionHasFocus() const; 206 bool SelectionHasFocus() const;
207 // TODO(hugoh): Rename the following 3 methods to: 207 void SetFrameIsFocused(bool);
208 void SetFocused(bool); // SetFrameIsFocused(), 208 bool FrameIsFocused() const { return focused_; }
209 bool IsFocused() const { return focused_; } // FrameIsFocused(), 209 bool FrameIsFocusedAndActive() const;
210 bool IsFocusedAndActive() const; // FrameIsFocusedAndActive().
211 void PageActivationChanged(); 210 void PageActivationChanged();
212 211
213 void SetUseSecureKeyboardEntryWhenActive(bool); 212 void SetUseSecureKeyboardEntryWhenActive(bool);
214 213
215 bool IsHandleVisible() const; 214 bool IsHandleVisible() const;
216 215
217 void UpdateSecureKeyboardEntryIfActive(); 216 void UpdateSecureKeyboardEntryIfActive();
218 217
219 // Returns true if a word is selected. 218 // Returns true if a word is selected.
220 bool SelectWordAroundPosition(const VisiblePosition&); 219 bool SelectWordAroundPosition(const VisiblePosition&);
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 313
315 } // namespace blink 314 } // namespace blink
316 315
317 #ifndef NDEBUG 316 #ifndef NDEBUG
318 // Outside the WebCore namespace for ease of invocation from gdb. 317 // Outside the WebCore namespace for ease of invocation from gdb.
319 void showTree(const blink::FrameSelection&); 318 void showTree(const blink::FrameSelection&);
320 void showTree(const blink::FrameSelection*); 319 void showTree(const blink::FrameSelection*);
321 #endif 320 #endif
322 321
323 #endif // FrameSelection_h 322 #endif // FrameSelection_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/SelectorChecker.cpp ('k') | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698