Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2876873002: [media] Make cdm_manager.h a conditional include. (Closed)

Created:
3 years, 7 months ago by sandersd (OOO until July 31)
Modified:
3 years, 7 months ago
Reviewers:
xhwang
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[media] Make cdm_manager.h a conditional include. Since the dep is also conditional, not doing this fails gn check. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2876873002 Cr-Commit-Position: refs/heads/master@{#471075} Committed: https://chromium.googlesource.com/chromium/src/+/49bd72acfbaf5ba49824c0a682a94d5178535c64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M media/gpu/android_video_decode_accelerator.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
sandersd (OOO until July 31)
3 years, 7 months ago (2017-05-11 19:15:32 UTC) #3
xhwang
lgtm
3 years, 7 months ago (2017-05-11 19:17:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876873002/1
3 years, 7 months ago (2017-05-11 20:07:30 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 21:23:34 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/49bd72acfbaf5ba49824c0a682a9...

Powered by Google App Engine
This is Rietveld 408576698