Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2876853007: Fix an issue that download fails for non-http(s) protocols (Closed)

Created:
3 years, 7 months ago by qinmin
Modified:
3 years, 7 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an issue that download fails for non-http(s) protocols DownloadManager.addCompletedDownload() only supports http/https uri or null This CL converts all non http/https uri to null BUG=714126 Review-Url: https://codereview.chromium.org/2876853007 Cr-Commit-Position: refs/heads/master@{#471860} Committed: https://chromium.googlesource.com/chromium/src/+/57bb4b6713175b902e2c4e19df6df3872d69e885

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
qinmin
PTAL
3 years, 7 months ago (2017-05-12 23:53:23 UTC) #2
David Trainor- moved to gerrit
lgtm https://codereview.chromium.org/2876853007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java (right): https://codereview.chromium.org/2876853007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java#newcode102 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java:102: // OriginalUri has to be null or non-empty, ...
3 years, 7 months ago (2017-05-14 05:55:15 UTC) #3
qinmin
https://codereview.chromium.org/2876853007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java (right): https://codereview.chromium.org/2876853007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java#newcode102 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java:102: // OriginalUri has to be null or non-empty, and ...
3 years, 7 months ago (2017-05-15 17:59:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876853007/20001
3 years, 7 months ago (2017-05-15 18:00:24 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 19:16:59 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/57bb4b6713175b902e2c4e19df6d...

Powered by Google App Engine
This is Rietveld 408576698