Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2876853003: Upstream position: sticky <th> tests to WPT (Closed)

Created:
3 years, 7 months ago by smcgruer
Modified:
3 years, 6 months ago
Reviewers:
flackr
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream position: sticky <th> tests to WPT BUG=699244 Review-Url: https://codereview.chromium.org/2876853003 Cr-Commit-Position: refs/heads/master@{#474744} Committed: https://chromium.googlesource.com/chromium/src/+/801c4b4606bec92bfa5ec4ef6900905eee920315

Patch Set 1 #

Patch Set 2 : Add bottom/right tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+732 lines, -185 lines) Patch
A third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-bottom.html View 1 1 chunk +127 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-bottom-ref.html View 1 1 chunk +62 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-left.html View 1 chunk +115 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-left-ref.html View 1 chunk +62 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-right.html View 1 1 chunk +115 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-right-ref.html View 1 1 chunk +62 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-top.html View 1 chunk +127 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-th-top-ref.html View 1 chunk +62 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-table-th-top.html View 1 chunk +0 lines, -116 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/sticky/sticky-table-th-top-expected.html View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
smcgruer
I've done top and left so far for <th>; plan is to add bottom and ...
3 years, 7 months ago (2017-05-12 14:11:35 UTC) #2
flackr
On 2017/05/12 14:11:35, smcgruer wrote: > I've done top and left so far for <th>; ...
3 years, 7 months ago (2017-05-12 18:21:41 UTC) #3
smcgruer
PTAL
3 years, 7 months ago (2017-05-19 15:16:42 UTC) #4
smcgruer
Ping for review?
3 years, 6 months ago (2017-05-25 13:35:22 UTC) #5
flackr
lgtm
3 years, 6 months ago (2017-05-25 14:14:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876853003/20001
3 years, 6 months ago (2017-05-25 14:30:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/464440)
3 years, 6 months ago (2017-05-25 16:43:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876853003/20001
3 years, 6 months ago (2017-05-25 18:14:41 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-05-25 19:17:17 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/801c4b4606bec92bfa5ec4ef6900...

Powered by Google App Engine
This is Rietveld 408576698