Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2876823003: Revert of [PageLoadMetrics] Reenable AdsMetrics and handle case where navigation aborts (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [PageLoadMetrics] Reenable AdsMetrics and handle case where navigation aborts (patchset #7 id:340001 of https://codereview.chromium.org/2861433005/ ) Reason for revert: Test is flaky, see https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/452154 Original issue's description: > [PageLoadMetrics] Reenable AdsMetrics and handle case where navigation aborts > > It turns out that a frame can abort and continue to load resources even if it > has no previous navigation. This happens if a doc.write overwrites the frame > navigation while the navigation is still provisional. > > This CL now labels all finished frame navigations (regardless of success) and > removes an incorrect dcheck. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > BUG=708570 > > Review-Url: https://codereview.chromium.org/2861433005 > Cr-Commit-Position: refs/heads/master@{#470701} > Committed: https://chromium.googlesource.com/chromium/src/+/6f3a10ddea2ee602ff61267ce3ed6a60c8e6ff71 TBR=bmcquade@chromium.org,csharrison@chromium.org,jkarlin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708570 Review-Url: https://codereview.chromium.org/2876823003 Cr-Commit-Position: refs/heads/master@{#471055} Committed: https://chromium.googlesource.com/chromium/src/+/1a94a262a90ca1f0dad5952b021f89628f1c81f7

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
Nico
Created Revert of [PageLoadMetrics] Reenable AdsMetrics and handle case where navigation aborts
3 years, 7 months ago (2017-05-11 20:18:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876823003/1
3 years, 7 months ago (2017-05-11 20:20:10 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 20:21:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a94a262a90ca1f0dad5952b021f...

Powered by Google App Engine
This is Rietveld 408576698