Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2876813004: [css-typed-om] styleMap should have SameObject extended attribute. (Closed)

Created:
3 years, 7 months ago by Hwanseung Lee
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-typed-om] styleMap should have SameObject extended attribute. styleMap of Element should have SameObject extended attribute. it indicates that when getting the value of the attribute on a given object, the same value must always be returned. https://drafts.css-houdini.org/css-typed-om-1/#inline-stylepropertymap-objects https://github.com/w3c/css-houdini-drafts/issues/160 BUG=545318 Review-Url: https://codereview.chromium.org/2876813004 Cr-Commit-Position: refs/heads/master@{#471678} Committed: https://chromium.googlesource.com/chromium/src/+/774a9a585165a9fc43d7de9d8b49c402dbcd2e6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/dom/Element.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Hwanseung Lee
PTAL, thank you.
3 years, 7 months ago (2017-05-13 06:27:33 UTC) #7
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-15 03:57:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876813004/1
3 years, 7 months ago (2017-05-15 04:09:21 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 05:51:10 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/774a9a585165a9fc43d7de9d8b49...

Powered by Google App Engine
This is Rietveld 408576698