Generate diffs for fields in ComputedStyle that use their public getters

third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

Index: third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
diff --git a/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 b/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
index ceb9657597ee2c714912264d3f81c2df46906717..37eb1ec82eef754db35beacfc574bb8ca107e3a7 100644
--- a/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
+++ b/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
@@ -5,25 +5,48 @@
   parameters: {
     // The name parameter represents the name of the function to be created.
 
-    // The fields that need to be diffed.
-    fields: {
+    fields_to_diff: {
+    },
+
+    // A map of expressions to diff (these can be public getters of fields or 
+    // functions that use fields to determine a value).

[alancutter (OOO until 2018), 2017/05/16 03:28:38]

Document the structure of the items here.

+    methods_to_diff: {
+      default: [],
     },
   },
   data: [
     {
         name: "ScrollAnchorDisablingPropertyChanged",
-        fields: ["width", "min-width", "max-width", "height", "min-height", "max-height", "margin-top", "margin-left", "margin-right", "margin-bottom", 
+        fields_to_diff: ["width", "min-width", "max-width", "height", "min-height", "max-height", "margin-top", "margin-left", "margin-right", "margin-bottom", 
                   "left", "right", "top", "bottom", "padding-top", 
                   "padding-left", "padding-right", "padding-bottom"]
     },
     {
         name: "DiffNeedsFullLayoutAndPaintInvalidation",
-        fields: ["padding-top", "padding-left", "padding-right", 
-                "padding-bottom"]
+        fields_to_diff: ["padding-top", "padding-left", "padding-right", 
+                "padding-bottom"],
+        methods_to_diff: [
+                            {

[alancutter (OOO until 2018), 2017/05/16 03:28:38]

I don't think alignment like this is suitable for arrays with many elements. I
think indentation like data has is more consistent and a better use of
horizontal space.

[nainar, 2017/05/16 03:46:13]

Done.

+                              method: "BorderLeftWidth()", 
+                              field_dependencies: ["border-left-width"]
+                            },
+                            {
+                              method: "BorderTopWidth()",
+                              field_dependencies: ["border-top-width"]
+                            },
+                            {
+                              method: "BorderBottomWidth()",
+                              field_dependencies: ["border-bottom-width"]
+                            },
+                            {
+                              method: "BorderRightWidth()",
+                              field_dependencies: ["border-right-width"]
+                            }
+                          ]
     },
     {
         name: "DiffNeedsFullLayout",
-        fields: ["width", "min-width", "max-width", "height", "min-height", "max-height", "box-sizing"]
+        fields_to_diff: ["width", "min-width", "max-width", "height", "min-height", "max-height", "box-sizing"]
     }
   ],
 }