Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

Issue 2876803003: Generate diffs for fields in ComputedStyle that use their public getters (Closed)
Patch Set: alancutter@'s suggestions Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 { 1 {
2 // This file specifies the fields we want to diff in the various diff function s 2 // This file specifies the fields we want to diff in the various diff function s
3 // in ComputedStyle. 3 // in ComputedStyle.
4 4
5 parameters: { 5 parameters: {
6 // The name parameter represents the name of the function to be created. 6 // The name parameter represents the name of the function to be created.
7 7
8 // The fields that need to be diffed. 8 fields_to_diff: {
9 fields: { 9 },
10
11 // A map of expressions to diff (these can be public getters of fields or
12 // functions that use fields to determine a value).
alancutter (OOO until 2018) 2017/05/16 03:28:38 Document the structure of the items here.
13 methods_to_diff: {
14 default: [],
10 }, 15 },
11 }, 16 },
12 data: [ 17 data: [
13 { 18 {
14 name: "ScrollAnchorDisablingPropertyChanged", 19 name: "ScrollAnchorDisablingPropertyChanged",
15 fields: ["width", "min-width", "max-width", "height", "min-height", "max -height", "margin-top", "margin-left", "margin-right", "margin-bottom", 20 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", "max-height", "margin-top", "margin-left", "margin-right", "margin-bottom",
16 "left", "right", "top", "bottom", "padding-top", 21 "left", "right", "top", "bottom", "padding-top",
17 "padding-left", "padding-right", "padding-bottom"] 22 "padding-left", "padding-right", "padding-bottom"]
18 }, 23 },
19 { 24 {
20 name: "DiffNeedsFullLayoutAndPaintInvalidation", 25 name: "DiffNeedsFullLayoutAndPaintInvalidation",
21 fields: ["padding-top", "padding-left", "padding-right", 26 fields_to_diff: ["padding-top", "padding-left", "padding-right",
22 "padding-bottom"] 27 "padding-bottom"],
28 methods_to_diff: [
29 {
alancutter (OOO until 2018) 2017/05/16 03:28:38 I don't think alignment like this is suitable for
nainar 2017/05/16 03:46:13 Done.
30 method: "BorderLeftWidth()",
31 field_dependencies: ["border-left-width"]
32 },
33 {
34 method: "BorderTopWidth()",
35 field_dependencies: ["border-top-width"]
36 },
37 {
38 method: "BorderBottomWidth()",
39 field_dependencies: ["border-bottom-width"]
40 },
41 {
42 method: "BorderRightWidth()",
43 field_dependencies: ["border-right-width"]
44 }
45 ]
23 }, 46 },
24 { 47 {
25 name: "DiffNeedsFullLayout", 48 name: "DiffNeedsFullLayout",
26 fields: ["width", "min-width", "max-width", "height", "min-height", "max -height", "box-sizing"] 49 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", "max-height", "box-sizing"]
27 } 50 }
28 ], 51 ],
29 } 52 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698