Generate diffs for fields in ComputedStyle that use their public getters

third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
index d7f6a5a100948c2b9b9ac23c35d99896599e2df3..5f71b7adcbffe8352c7830a59881d48e5469c524 100644
--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
@@ -114,6 +114,7 @@ class CORE_EXPORT ComputedStyleBase {
 
   {% for name, groups_to_diff in diff_functions_map.items() %}
   bool {{name}}(const T& other) const {
+    const T& self = static_cast<const T&>(*this);

[nainar, 2017/05/12 06:48:27]

Can't decide if this should be in this tmpl file or field.tmpl

[shend, 2017/05/12 06:59:17]

Should be here. If we want to use multiple fieldwise_diffs, then we don't want
to generate this code multiple times.

Nit: To do this super-properly, we would pass "self" to fieldwise_diff as a
parameter, so fieldwise_diff doesn't assume that "self" is always called "self".
No strong opinion about this though, as other Jinja macros violate this as well.

[nainar, 2017/05/12 07:07:47]

yup, passing self into fieldwise_diff

     {{fieldwise_diff(groups_to_diff)|indent(2)}}
     return false;
   }