Generate diffs for fields in ComputedStyle that use their public getters

third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

 {% from 'macros.tmpl' import license, print_if %}
 {% from 'fields/field.tmpl' import encode, getter_expression, setter_expression, declare_storage, fieldwise_compare, fieldwise_copy, fieldwise_diff %}
 {% from 'fields/group.tmpl' import define_field_group_class %}
 {{license()}}
 
 #ifndef ComputedStyleBase_h
 #define ComputedStyleBase_h
 
 #include "core/style/ComputedStyleConstants.h"
 #include "core/CoreExport.h"
@@ skipping 96 matching lines @@
   void PropagateIndependentInheritedProperties(
       const ComputedStyleBase& parentStyle) {
     {% for field in computed_style.all_fields if field.is_property and field.is_independent %}
     if ({{field.is_inherited_method_name}}())
       {{setter_expression(field)}} = parentStyle.{{getter_expression(field)}};
     {% endfor %}
   }
 
   {% for name, groups_to_diff in diff_functions_map.items() %}
   bool {{name}}(const T& other) const {
+    const T& self = static_cast<const T&>(*this);

[nainar, 2017/05/12 06:48:27]

Can't decide if this should be in this tmpl file or field.tmpl

[shend, 2017/05/12 06:59:17]

Should be here. If we want to use multiple fieldwise_diffs, then we don't want
to generate this code multiple times.

Nit: To do this super-properly, we would pass "self" to fieldwise_diff as a
parameter, so fieldwise_diff doesn't assume that "self" is always called "self".
No strong opinion about this though, as other Jinja macros violate this as well.

[nainar, 2017/05/12 07:07:47]

yup, passing self into fieldwise_diff

     {{fieldwise_diff(groups_to_diff)|indent(2)}}
     return false;
   }
   {% endfor %}
 
   // Fields.
   // TODO(sashab): Remove initialFoo() static methods and update callers to
   // use resetFoo(), which can be more efficient.
 
   {% for field in computed_style.all_fields %}
@@ skipping 43 matching lines @@
 
  private:
   {% for field in computed_style.fields %}
   {{declare_storage(field)}}
   {% endfor %}
 };
 
 } // namespace blink
 
 #endif // ComputedStyleBase_h