Improve subframe navigation tracking.

Improve subframe navigation tracking.

This change improves the logic for deciding whether to track a subframe nav.

1. only track if the nav's main frame matches the main frame of the currently
   committed load in the web contents
2. otherwise, always return early, since we don't want to run any of the
   subsequent MWCO::DidFinishNavigation logic on subframes.

BUG=721526
Review-Url: https://codereview.chromium.org/2876793004
Cr-Commit-Position: refs/heads/master@{#471146}
Committed: https://chromium.googlesource.com/chromium/src/+/356b56ebd085219c574858880d8ef0d15226bfda

[Bryan McQuade, 2017-05-11 20:40:04]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 20:41:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2017-05-11 20:41:35]

Description was changed from

==========
Improve subframe navigation tracking.

BUG=
==========

to

==========
Improve subframe navigation tracking.

This change improves the logic for deciding whether to track a subframe nav.

1. only track if the nav's main frame matches the main frame of the currently
   committed load in the web contents
2. otherwise, always return early, since we don't want to run any of the
   subsequent MWCO::DidFinishNavigation logic on subframes.

BUG=
==========

[Bryan McQuade, 2017-05-11 20:43:28]

Description was changed from

==========
Improve subframe navigation tracking.

This change improves the logic for deciding whether to track a subframe nav.

1. only track if the nav's main frame matches the main frame of the currently
   committed load in the web contents
2. otherwise, always return early, since we don't want to run any of the
   subsequent MWCO::DidFinishNavigation logic on subframes.

BUG=
==========

to

==========
Improve subframe navigation tracking.

This change improves the logic for deciding whether to track a subframe nav.

1. only track if the nav's main frame matches the main frame of the currently
   committed load in the web contents
2. otherwise, always return early, since we don't want to run any of the
   subsequent MWCO::DidFinishNavigation logic on subframes.

BUG=721526
==========

[Bryan McQuade, 2017-05-11 20:44:38]

bmcquade@chromium.org changed reviewers:
+ jkarlin@chromium.org

[Bryan McQuade, 2017-05-11 20:45:44]

I decided to create a minimal change with the subframe commit tracking logic you
proposed, since some of my changes want this as well. I also noticed that we
probably always want to return early if we're dealing with a non-main frame nav,
since the logic below is always specific to main frames. Take a look and see
what you think, thanks!

[jkarlin, 2017-05-11 21:44:14]

lgtm

[commit-bot: I haz the power, 2017-05-11 22:32:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 22:32:53]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2017-05-12 00:17:12]

The CQ bit was checked by bmcquade@chromium.org

[commit-bot: I haz the power, 2017-05-12 00:18:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 00:35:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494548232380950, "parent_rev":
"29bd77bcacd88ec3d568905098484c83c988d4fd", "commit_rev":
"356b56ebd085219c574858880d8ef0d15226bfda"}

[commit-bot: I haz the power, 2017-05-12 00:35:38]

Description was changed from

==========
Improve subframe navigation tracking.

This change improves the logic for deciding whether to track a subframe nav.

1. only track if the nav's main frame matches the main frame of the currently
   committed load in the web contents
2. otherwise, always return early, since we don't want to run any of the
   subsequent MWCO::DidFinishNavigation logic on subframes.

BUG=721526
==========

to

==========
Improve subframe navigation tracking.

This change improves the logic for deciding whether to track a subframe nav.

1. only track if the nav's main frame matches the main frame of the currently
   committed load in the web contents
2. otherwise, always return early, since we don't want to run any of the
   subsequent MWCO::DidFinishNavigation logic on subframes.

BUG=721526

Review-Url: https://codereview.chromium.org/2876793004
Cr-Commit-Position: refs/heads/master@{#471146}
Committed:
https://chromium.googlesource.com/chromium/src/+/356b56ebd085219c574858880d8e...
==========

[commit-bot: I haz the power, 2017-05-12 00:35:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/356b56ebd085219c574858880d8e...