Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2876783002: Moved InstalledAppProvider Android impl from content into chrome. (Closed)

Created:
3 years, 7 months ago by Matt Giuca
Modified:
3 years, 7 months ago
Reviewers:
Ted C, Maria
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, agrieve+watch_chromium.org, darin (slow to review), chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved InstalledAppProvider Android impl from content into chrome. This is necessary to allow the implementation to use Android Play services. BUG=721228 Review-Url: https://codereview.chromium.org/2876783002 Cr-Commit-Position: refs/heads/master@{#471413} Committed: https://chromium.googlesource.com/chromium/src/+/83689098f7e7bb61de20e9c74335c20121f8a9e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1390 lines) Patch
A + chrome/android/java/src/org/chromium/chrome/browser/installedapp/InstalledAppProviderFactory.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/installedapp/InstalledAppProviderImpl.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/installedapp/PackageHash.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 2 chunks +5 lines, -0 lines 0 comments Download
A + chrome/android/junit/src/org/chromium/chrome/browser/installedapp/InstalledAppProviderTest.java View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/junit/src/org/chromium/chrome/browser/installedapp/PackageHashTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java View 3 chunks +0 lines, -14 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderFactory.java View 1 chunk +0 lines, -55 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderImpl.java View 1 chunk +0 lines, -326 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/installedapp/PackageHash.java View 1 chunk +0 lines, -98 lines 0 comments Download
D content/public/android/junit/src/org/chromium/content/browser/installedapp/InstalledAppProviderTest.java View 1 chunk +0 lines, -851 lines 0 comments Download
D content/public/android/junit/src/org/chromium/content/browser/installedapp/PackageHashTest.java View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Matt Giuca
See https://crbug.com/721228 for discussion. This was requested by Maria (so adding Maria as reviewer, who ...
3 years, 7 months ago (2017-05-11 07:26:27 UTC) #4
Maria
lgtm
3 years, 7 months ago (2017-05-11 16:43:52 UTC) #7
Ted C
lgtm
3 years, 7 months ago (2017-05-12 16:30:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876783002/1
3 years, 7 months ago (2017-05-12 16:46:21 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 19:44:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/83689098f7e7bb61de20e9c74335...

Powered by Google App Engine
This is Rietveld 408576698