Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2876753002: Add more methods to CWVScrollView and CWVScrollViewDelegate. (Closed)

Created:
3 years, 7 months ago by Hiroshi Ichikawa
Modified:
3 years, 7 months ago
Reviewers:
michaeldo
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more methods to CWVScrollView and CWVScrollViewDelegate. Review-Url: https://codereview.chromium.org/2876753002 Cr-Commit-Position: refs/heads/master@{#471324} Committed: https://chromium.googlesource.com/chromium/src/+/69aaafa1563d9052b511131919c8b638af5ec914

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Add more methods. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M ios/web_view/internal/cwv_scroll_view.mm View 1 2 3 chunks +32 lines, -0 lines 0 comments Download
M ios/web_view/public/cwv_scroll_view.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M ios/web_view/public/cwv_scroll_view_delegate.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Hiroshi Ichikawa
3 years, 7 months ago (2017-05-12 09:50:59 UTC) #2
michaeldo
lgtm!
3 years, 7 months ago (2017-05-12 14:44:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876753002/40001
3 years, 7 months ago (2017-05-12 16:02:46 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 16:14:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/69aaafa1563d9052b511131919c8...

Powered by Google App Engine
This is Rietveld 408576698