Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2876723002: Fix behaviour of shadow interpolation with mismatched list lengths (Closed)

Created:
3 years, 7 months ago by alancutter (OOO until 2018)
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fix behaviour of shadow interpolation with mismatched list lengths For shadow properties like box-shadow and text-shadow we were incorrectly interpolating shadow lists with mismatched lengths. The old behaviour would repeat each list to the lowest common multiple, the correct behaviour is to pad the shorted list with "zero" shadows. Spec: https://www.w3.org/TR/css3-transitions/#animatable-types This change adds the "padding" behaviour to list interpolation and composition and updates our shadow animation test cases to match spec behaviour. BUG=713674 Review-Url: https://codereview.chromium.org/2844213002 Cr-Commit-Position: refs/heads/master@{#470205} (cherry picked from commit 4aaaf95a33ef49f61476ca1f3699700fa7ea3fe8) Review-Url: https://codereview.chromium.org/2876723002 . Cr-Commit-Position: refs/branch-heads/3071@{#506} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/ff1b1926fea47a35bfc0c9729a020ec20c8fa5f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -153 lines) Patch
M third_party/WebKit/LayoutTests/animations/composition/box-shadow-composition.html View 4 chunks +30 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/composition/text-shadow-composition.html View 4 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/interpolation/box-shadow-interpolation.html View 5 chunks +69 lines, -55 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/interpolation/text-shadow-interpolation.html View 5 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/responsive/box-shadow-responsive.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/transitions/multiple-shadow-transitions.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/transitions/multiple-shadow-transitions-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ListInterpolationFunctions.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ListInterpolationFunctions.cpp View 7 chunks +147 lines, -38 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
alancutter (OOO until 2018)
3 years, 7 months ago (2017-05-11 01:49:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ff1b1926fea47a35bfc0c9729a020ec20c8fa5f6.

Powered by Google App Engine
This is Rietveld 408576698