Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2876703002: [mDns] Move dns_sd_registry from extension/api/mdns to media/router/discovery/mdns (Closed)

Created:
3 years, 7 months ago by zhaobin
Modified:
3 years, 7 months ago
Reviewers:
mark a. foltz, Devlin
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, imcheng+watch_chromium.org, mfoltz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[mDns] Move dns_sd_registry from extension/api/mdns to media/router/discovery/mdns Move DnsSdRegistry and related classed to MR folder so that it can be used by CastMediaSinkService. BUG=687377 Review-Url: https://codereview.chromium.org/2876703002 Cr-Commit-Position: refs/heads/master@{#472149} Committed: https://chromium.googlesource.com/chromium/src/+/b9946bb24dac07cb38b87697114678f6f416b20d

Patch Set 1 #

Patch Set 2 : fix browser_tests compile errors #

Patch Set 3 : rebase with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -923 lines) Patch
M chrome/browser/extensions/BUILD.gn View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/browser/extensions/api/mdns/dns_sd_delegate.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/extensions/api/mdns/dns_sd_delegate.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/extensions/api/mdns/dns_sd_device_lister.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/extensions/api/mdns/dns_sd_device_lister.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/extensions/api/mdns/dns_sd_registry.h View 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/browser/extensions/api/mdns/dns_sd_registry.cc View 1 chunk +0 lines, -242 lines 0 comments Download
D chrome/browser/extensions/api/mdns/dns_sd_registry_unittest.cc View 1 chunk +0 lines, -264 lines 0 comments Download
M chrome/browser/extensions/api/mdns/mdns_api.h View 6 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/mdns/mdns_api.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/mdns/mdns_api_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/mdns/mdns_apitest.cc View 1 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/media/router/discovery/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
A + chrome/browser/media/router/discovery/mdns/dns_sd_delegate.h View 3 chunks +7 lines, -10 lines 0 comments Download
A + chrome/browser/media/router/discovery/mdns/dns_sd_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/media/router/discovery/mdns/dns_sd_device_lister.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/media/router/discovery/mdns/dns_sd_device_lister.cc View 4 chunks +8 lines, -13 lines 0 comments Download
A + chrome/browser/media/router/discovery/mdns/dns_sd_registry.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/media/router/discovery/mdns/dns_sd_registry.cc View 5 chunks +11 lines, -15 lines 0 comments Download
A + chrome/browser/media/router/discovery/mdns/dns_sd_registry_unittest.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 49 (39 generated)
zhaobin
3 years, 7 months ago (2017-05-11 01:23:14 UTC) #2
mark a. foltz
lgtm This looks as good a place as any. The mDNS API will remain as ...
3 years, 7 months ago (2017-05-11 17:13:20 UTC) #3
zhaobin
+rdevlin.cronin@ to review: chrome/browser/extensions/BUILD.gn
3 years, 7 months ago (2017-05-12 17:50:27 UTC) #17
Devlin
chrome/browser/extensions/BUILD.gn lgtm
3 years, 7 months ago (2017-05-12 20:53:33 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876703002/20001
3 years, 7 months ago (2017-05-12 21:19:59 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/443542)
3 years, 7 months ago (2017-05-12 23:18:02 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876703002/20001
3 years, 7 months ago (2017-05-15 17:47:47 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/426841)
3 years, 7 months ago (2017-05-15 18:57:26 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876703002/40001
3 years, 7 months ago (2017-05-16 17:33:12 UTC) #46
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 17:47:07 UTC) #49
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b9946bb24dac07cb38b876971146...

Powered by Google App Engine
This is Rietveld 408576698