[PageLoadMetrics] Disable AdsMetrics

[PageLoadMetrics] Disable AdsMetrics

Still causing crashes, so disable.

I have a fix in the works but it will take a bit more time so disabling in the meanwhile.

TBR=bmcquade
NOTRY=true

BUG=721369
Review-Url: https://codereview.chromium.org/2876693005
Cr-Commit-Position: refs/heads/master@{#471022}
Committed: https://chromium.googlesource.com/chromium/src/+/5c011426b2ca0721f632cab58f55a2e7ca6781b2

[jkarlin, 2017-05-11 18:35:17]

Description was changed from

==========
[PageLoadMetrics] Disable AdsMetrics

Still causing crashes, so disable.

I have a fix in the works but it will take a bit more time so disabling in the
meanwhile.

BUG=721369
==========

to

==========
[PageLoadMetrics] Disable AdsMetrics

Still causing crashes, so disable.

I have a fix in the works but it will take a bit more time so disabling in the
meanwhile.

TBR=bmcquade
NOTRY=true

BUG=721369
==========

[jkarlin, 2017-05-11 18:35:40]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2017-05-11 18:36:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-05-11 18:46:30]

csharrison@chromium.org changed reviewers:
+ csharrison@chromium.org

[Charlie Harrison, 2017-05-11 18:46:30]

LGTM

[commit-bot: I haz the power, 2017-05-11 18:46:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494527740875580, "parent_rev":
"f832a981cfc5f907f47f287c9d2eb9582c623744", "commit_rev":
"5c011426b2ca0721f632cab58f55a2e7ca6781b2"}

[commit-bot: I haz the power, 2017-05-11 18:46:45]

Description was changed from

==========
[PageLoadMetrics] Disable AdsMetrics

Still causing crashes, so disable.

I have a fix in the works but it will take a bit more time so disabling in the
meanwhile.

TBR=bmcquade
NOTRY=true

BUG=721369
==========

to

==========
[PageLoadMetrics] Disable AdsMetrics

Still causing crashes, so disable.

I have a fix in the works but it will take a bit more time so disabling in the
meanwhile.

TBR=bmcquade
NOTRY=true

BUG=721369

Review-Url: https://codereview.chromium.org/2876693005
Cr-Commit-Position: refs/heads/master@{#471022}
Committed:
https://chromium.googlesource.com/chromium/src/+/5c011426b2ca0721f632cab58f55...
==========

[commit-bot: I haz the power, 2017-05-11 18:46:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5c011426b2ca0721f632cab58f55...

[Charlie Harrison, 2017-05-11 18:46:56]

BTW make sure you list the people you TBR in the reviewers field, otherwise they
won't get an email that you TBRd them

[James Cook, 2017-05-11 20:25:32]

On 2017/05/11 18:46:56, Charlie Harrison wrote:
> BTW make sure you list the people you TBR in the reviewers field, otherwise
they
> won't get an email that you TBRd them

Chrome OS gardener here: I'm seeing failures in
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
for AdsPageLoadMetricsObserverBrowserTest.DocOverwritesNavigation

Does something else need to be disabled?

I would revert this CL, but it looks like you're turning something off for
crashes.

[jkarlin, 2017-05-11 21:47:59]

On 2017/05/11 20:25:32, James Cook (sheriff - slow) wrote:
> On 2017/05/11 18:46:56, Charlie Harrison wrote:
> > BTW make sure you list the people you TBR in the reviewers field, otherwise
> they
> > won't get an email that you TBRd them
> 
> Chrome OS gardener here: I'm seeing failures in
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
> for AdsPageLoadMetricsObserverBrowserTest.DocOverwritesNavigation
> 
> Does something else need to be disabled?
> 
> I would revert this CL, but it looks like you're turning something off for
> crashes.

That's what I get for using NOTRY. Sorry about that. Will fix.

[findit-for-me, 2017-05-11 22:23:46]

Findit (https://goo.gl/kROfz5) identified this CL at revision 471022 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...