DevTools: simplify network throttling presets

DevTools: simplify network throttling presets

BUG=721112
Review-Url: https://codereview.chromium.org/2876683002
Cr-Commit-Position: refs/heads/master@{#471950}
Committed: https://chromium.googlesource.com/chromium/src/+/8a4e4200086bc67a61c83d60edfb450844377e5a

[chenwilliam, 2017-05-11 01:15:09]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[chenwilliam, 2017-05-11 01:15:10]

ptal

[dgozman, 2017-05-11 22:49:05]

https://codereview.chromium.org/2876683002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js
(right):

https://codereview.chromium.org/2876683002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js:224:
{title: 'WiFi', download: 100 * 1024 * 1024 / 8, upload: 100 * 1024 * 1024 / 8,
latency: 60}
Let's remove WiFi.

https://codereview.chromium.org/2876683002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSettingsTab.js
(right):

https://codereview.chromium.org/2876683002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSettingsTab.js:71:
if (editable)
You can revert these as we are not going to show default ones.

[chenwilliam, 2017-05-12 22:43:04]

ptal. thanks.

https://codereview.chromium.org/2876683002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js
(right):

https://codereview.chromium.org/2876683002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js:224:
{title: 'WiFi', download: 100 * 1024 * 1024 / 8, upload: 100 * 1024 * 1024 / 8,
latency: 60}
On 2017/05/11 22:49:04, dgozman wrote:
> Let's remove WiFi.

Done.

https://codereview.chromium.org/2876683002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSettingsTab.js
(right):

https://codereview.chromium.org/2876683002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSettingsTab.js:71:
if (editable)
On 2017/05/11 22:49:04, dgozman wrote:
> You can revert these as we are not going to show default ones.

Done.

https://codereview.chromium.org/2876683002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js
(right):

https://codereview.chromium.org/2876683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js:222:
{title: 'Slow 3G', download: 500 * 1024 / 8 * .8, upload: 500 * 1024 / 8 * .8,
latency: 400 * 5},
Fixed my slow 3g adjustment numbers. Caught an error in how I ran some of the
benchmarking so these are the updated correct numbers.

[dgozman, 2017-05-13 00:11:17]

lgtm

[chenwilliam, 2017-05-13 00:16:45]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2017-05-13 00:17:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 00:57:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 00:57:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chenwilliam, 2017-05-15 18:36:11]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-05-15 18:36:12]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2876683002/#ps60001
(title: "update browser test")

[commit-bot: I haz the power, 2017-05-15 18:37:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 19:33:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 19:33:47]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chenwilliam, 2017-05-15 22:37:32]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2017-05-15 22:38:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 23:56:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494887852508930,
"parent_rev": "680ec74a33fcffefd0b1ed6a39686bc8451d80ab", "commit_rev":
"8a4e4200086bc67a61c83d60edfb450844377e5a"}

[commit-bot: I haz the power, 2017-05-15 23:56:31]

Description was changed from

==========
DevTools: simplify network throttling presets

BUG=721112
==========

to

==========
DevTools: simplify network throttling presets

BUG=721112

Review-Url: https://codereview.chromium.org/2876683002
Cr-Commit-Position: refs/heads/master@{#471950}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a4e4200086bc67a61c83d60edfb...
==========

[commit-bot: I haz the power, 2017-05-15 23:56:32]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8a4e4200086bc67a61c83d60edfb...