[Web Payments] Add data attribution string to dialog

components/payments/content/payment_response_helper.cc

Index: components/payments/content/payment_response_helper.cc
diff --git a/components/payments/content/payment_response_helper.cc b/components/payments/content/payment_response_helper.cc
index 9a3a8e5e8766041baaae1845d9b8f36913d9ae64..420fb4309dbe03831d47e33ca6f1a3459916fdcf 100644
--- a/components/payments/content/payment_response_helper.cc
+++ b/components/payments/content/payment_response_helper.cc
@@ -4,6 +4,8 @@
 
 #include "components/payments/content/payment_response_helper.h"
 
+#include <string>
+
 #include "base/strings/string_split.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_country.h"
@@ -61,9 +63,9 @@ PaymentResponseHelper::PaymentResponseHelper(
   // Start to get the instrument details. Will call back into
   // OnInstrumentDetailsReady.
   selected_instrument_->InvokePaymentApp(this);
-};
+}
 
-PaymentResponseHelper::~PaymentResponseHelper(){};
+PaymentResponseHelper::~PaymentResponseHelper() {}
 
 // static
 mojom::PaymentAddressPtr
@@ -185,6 +187,7 @@ void PaymentResponseHelper::GeneratePaymentResponse() {
   }
 
   delegate_->OnPaymentResponseReady(std::move(payment_response));
+  payment_request_delegate_->MarkFirstTransactionAsCompleted();

[Mathieu, 2017/05/11 00:28:04]

probably fine to write to the pref directly in
PaymentRequest::OnPaymentResponseAvailable without the need for the delegate?

you have access to web_contents()->GetBrowserContext() there 

[anthonyvd, 2017/05/11 00:56:46]

Unfortunately, the PrefService hangs off Profile, which is in chrome/browser so
I can't get to prefs directly from here.

[Mathieu, 2017/05/11 01:08:37]

PaymentRequest::OnPaymentResponseAvailable could still do it if it had
delegate_->GetPrefService, which is a slightly more reusable pattern!

[Mathieu, 2017/05/11 01:20:25]

Actually another review reminds me, should probably be PaymentRequest::Complete

[anthonyvd, 2017/05/11 13:24:42]

Done.

 }
 
 }  // namespace payments