[Web Payments] Add data attribution string to dialog

components/payments/content/payment_response_helper.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/payments/content/payment_response_helper.h"
 
+#include <string>
+
 #include "base/strings/string_split.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_country.h"
 #include "components/autofill/core/browser/autofill_data_util.h"
 #include "components/autofill/core/browser/autofill_type.h"
 #include "components/payments/content/payment_request_spec.h"
 #include "components/payments/core/payment_request_data_util.h"
 #include "components/payments/core/payment_request_delegate.h"
 
 namespace payments {
@@ skipping 37 matching lines @@
     }
 
     payment_request_delegate_->GetAddressNormalizer()
         ->StartAddressNormalization(*selected_shipping_profile, country_code,
                                     /*timeout_seconds=*/5, this);
   }
 
   // Start to get the instrument details. Will call back into
   // OnInstrumentDetailsReady.
   selected_instrument_->InvokePaymentApp(this);
-};
+}
 
-PaymentResponseHelper::~PaymentResponseHelper(){};
+PaymentResponseHelper::~PaymentResponseHelper() {}
 
 // static
 mojom::PaymentAddressPtr
 PaymentResponseHelper::GetMojomPaymentAddressFromAutofillProfile(
     const autofill::AutofillProfile& profile,
     const std::string& app_locale) {
   mojom::PaymentAddressPtr payment_address = mojom::PaymentAddress::New();
 
   payment_address->country =
       base::UTF16ToUTF8(profile.GetRawInfo(autofill::ADDRESS_HOME_COUNTRY));
@@ skipping 101 matching lines @@
             autofill::AutofillType(autofill::PHONE_HOME_WHOLE_NUMBER),
             app_locale_));
 
     const std::string default_region_code =
         autofill::AutofillCountry::CountryCodeForLocale(app_locale_);
     payment_response->payer_phone =
         data_util::FormatPhoneForResponse(original_number, default_region_code);
   }
 
   delegate_->OnPaymentResponseReady(std::move(payment_response));
+  payment_request_delegate_->MarkFirstTransactionAsCompleted();

[Mathieu, 2017/05/11 00:28:04]

probably fine to write to the pref directly in
PaymentRequest::OnPaymentResponseAvailable without the need for the delegate?

you have access to web_contents()->GetBrowserContext() there 

[anthonyvd, 2017/05/11 00:56:46]

Unfortunately, the PrefService hangs off Profile, which is in chrome/browser so
I can't get to prefs directly from here.

[Mathieu, 2017/05/11 01:08:37]

PaymentRequest::OnPaymentResponseAvailable could still do it if it had
delegate_->GetPrefService, which is a slightly more reusable pattern!

[Mathieu, 2017/05/11 01:20:25]

Actually another review reminds me, should probably be PaymentRequest::Complete

[anthonyvd, 2017/05/11 13:24:42]

Done.

 }
 
 }  // namespace payments