Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 287663003: Do not generate EventTarget.cpp which is not used in the build. (Closed)

Created:
6 years, 7 months ago by c.shu
Modified:
6 years, 7 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Do not generate EventTarget.cpp which is not used in the build. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174247

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/build/scripts/make_event_factory.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
c.shu
The auto-generated EventTarget.cpp is not used anywhere in the build and I think we should ...
6 years, 7 months ago (2014-05-13 20:56:29 UTC) #1
Nils Barth (inactive)
Sounds sensible, thanks! Adam, could you take a look?
6 years, 7 months ago (2014-05-14 02:56:23 UTC) #2
eseidel
lgtm https://codereview.chromium.org/287663003/diff/1/Source/build/scripts/make_event_factory.py File Source/build/scripts/make_event_factory.py (right): https://codereview.chromium.org/287663003/diff/1/Source/build/scripts/make_event_factory.py#newcode67 Source/build/scripts/make_event_factory.py:67: if self.namespace == 'EventTarget': Feels like an odd ...
6 years, 7 months ago (2014-05-16 21:15:43 UTC) #3
c.shu
On 2014/05/16 21:15:43, eseidel wrote: > lgtm > > https://codereview.chromium.org/287663003/diff/1/Source/build/scripts/make_event_factory.py > File Source/build/scripts/make_event_factory.py (right): > ...
6 years, 7 months ago (2014-05-16 21:21:23 UTC) #4
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 7 months ago (2014-05-16 23:59:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/287663003/1
6 years, 7 months ago (2014-05-17 00:00:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-17 00:00:32 UTC) #7
commit-bot: I haz the power
Failed to apply patch for Source/build/scripts/make_event_factory.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-17 00:00:33 UTC) #8
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 7 months ago (2014-05-17 00:22:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/287663003/20001
6 years, 7 months ago (2014-05-17 00:22:43 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 18:23:14 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-18 08:23:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/8226)
6 years, 7 months ago (2014-05-18 08:24:00 UTC) #13
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 7 months ago (2014-05-18 12:33:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/287663003/20001
6 years, 7 months ago (2014-05-18 12:34:04 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 07:27:20 UTC) #16
Message was sent while issue was closed.
Change committed as 174247

Powered by Google App Engine
This is Rietveld 408576698