Do not generate EventTarget.cpp which is not used in the build.

Do not generate EventTarget.cpp which is not used in the build.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174247

[c.shu, 2014-05-13 20:56:29]

The auto-generated EventTarget.cpp is not used anywhere in the build and I think
we should not generate it.

[Nils Barth (inactive), 2014-05-14 02:56:23]

Sounds sensible, thanks!
Adam, could you take a look?

[eseidel, 2014-05-16 21:15:43]

lgtm

https://codereview.chromium.org/287663003/diff/1/Source/build/scripts/make_ev...
File Source/build/scripts/make_event_factory.py (right):

https://codereview.chromium.org/287663003/diff/1/Source/build/scripts/make_ev...
Source/build/scripts/make_event_factory.py:67: if self.namespace ==
'EventTarget':
Feels like an odd place to disable this, but OK.

[c.shu, 2014-05-16 21:21:23]

On 2014/05/16 21:15:43, eseidel wrote:
> lgtm
> 
>
https://codereview.chromium.org/287663003/diff/1/Source/build/scripts/make_ev...
> File Source/build/scripts/make_event_factory.py (right):
> 
>
https://codereview.chromium.org/287663003/diff/1/Source/build/scripts/make_ev...
> Source/build/scripts/make_event_factory.py:67: if self.namespace ==
> 'EventTarget':
> Feels like an odd place to disable this, but OK.

You are right. It's a bit hacky. But we have to generate other files like
EventTargetHeaders.h which are also triggered by calling make_event_factory. So
I could not just remove the line that calls make_event_factory.

[c.shu, 2014-05-16 23:59:42]

The CQ bit was checked by c.shu@samsung.com

[commit-bot: I haz the power, 2014-05-17 00:00:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/c.shu@samsung.com/287663003/1

[commit-bot: I haz the power, 2014-05-17 00:00:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-17 00:00:33]

Failed to apply patch for Source/build/scripts/make_event_factory.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/build/scripts/make_event_factory.py
  Hunk #1 FAILED at 64.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/build/scripts/make_event_factory.py.rej

Patch:       Source/build/scripts/make_event_factory.py
Index: Source/build/scripts/make_event_factory.py
diff --git a/Source/build/scripts/make_event_factory.py
b/Source/build/scripts/make_event_factory.py
index
16d442c86373f9120879aa6bf897e5ed3d46a559..21804a514591f0935039312c936bcd8f31195942
100755
--- a/Source/build/scripts/make_event_factory.py
+++ b/Source/build/scripts/make_event_factory.py
@@ -64,6 +64,8 @@ class EventFactoryWriter(name_macros.Writer):
 
     def __init__(self, in_file_path):
         super(EventFactoryWriter, self).__init__(in_file_path)
+        if self.namespace == 'EventTarget':
+            return
         self._outputs[(self.namespace + ".cpp")] = self.generate_implementation
 
     @template_expander.use_jinja('EventFactory.cpp.tmpl', filters=filters)

[c.shu, 2014-05-17 00:22:26]

The CQ bit was checked by c.shu@samsung.com

[commit-bot: I haz the power, 2014-05-17 00:22:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/c.shu@samsung.com/287663003/20001

[commit-bot: I haz the power, 2014-05-17 18:23:14]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/7845)

[commit-bot: I haz the power, 2014-05-18 08:23:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-18 08:24:00]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/8226)

[c.shu, 2014-05-18 12:33:44]

The CQ bit was checked by c.shu@samsung.com

[commit-bot: I haz the power, 2014-05-18 12:34:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/c.shu@samsung.com/287663003/20001

[commit-bot: I haz the power, 2014-05-19 07:27:20]

Change committed as 174247