Source/build/scripts/make_event_factory.py - Issue 287663003: Do not generate EventTarget.cpp which is not used in the build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/build/scripts/make_event_factory.py

Issue 287663003: Do not generate EventTarget.cpp which is not used in the build. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebaseline Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/build/scripts/make_event_factory.py

diff --git a/Source/build/scripts/make_event_factory.py b/Source/build/scripts/make_event_factory.py

index 6bb46b8199c13ced67c9c56ff39ad23688101345..1bd736bc4402a842f89fa093903b059e53a097aa 100755

--- a/Source/build/scripts/make_event_factory.py

+++ b/Source/build/scripts/make_event_factory.py

@@ -65,6 +65,8 @@ class EventFactoryWriter(name_macros.Writer):

def __init__(self, in_file_path):

super(EventFactoryWriter, self).__init__(in_file_path)

+ if self.namespace == 'EventTarget':

+ return

self._outputs[(self.namespace + self.suffix + ".cpp")] = self.generate_implementation

@template_expander.use_jinja('EventFactory.cpp.tmpl', filters=filters)

« no previous file with comments | « no previous file | no next file » | no next file with comments »