Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2876623003: [Devtools] Added character limit on name column in devtools (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 872 matching lines...) Expand 10 before | Expand all | Expand 10 after
883 this._request.populateImageSource(previewImage); 883 this._request.populateImageSource(previewImage);
884 884
885 iconElement = createElementWithClass('div', 'icon'); 885 iconElement = createElementWithClass('div', 'icon');
886 iconElement.appendChild(previewImage); 886 iconElement.appendChild(previewImage);
887 } else { 887 } else {
888 iconElement = createElementWithClass('img', 'icon'); 888 iconElement = createElementWithClass('img', 'icon');
889 } 889 }
890 iconElement.classList.add(this._request.resourceType().name()); 890 iconElement.classList.add(this._request.resourceType().name());
891 891
892 cell.appendChild(iconElement); 892 cell.appendChild(iconElement);
893 cell.createTextChild(this._request.networkManager().target().decorateLabel(t his._request.name())); 893 cell.createTextChild(this._request.networkManager().target().decorateLabel(t his._request.name()).trimMiddle(100));
pfeldman 2017/05/11 01:01:57 trim name, not the decorated label.
894 this._appendSubtitle(cell, this._request.path()); 894 this._appendSubtitle(cell, this._request.path());
895 cell.title = this._request.url(); 895 cell.title = this._request.url();
896 } 896 }
897 897
898 /** 898 /**
899 * @param {!Element} cell 899 * @param {!Element} cell
900 * @param {!ProductRegistry.Registry} productRegistry 900 * @param {!ProductRegistry.Registry} productRegistry
901 */ 901 */
902 _renderProductCell(cell, productRegistry) { 902 _renderProductCell(cell, productRegistry) {
903 var rowElement = this.existingElement(); 903 var rowElement = this.existingElement();
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
1090 * @param {boolean=} supressSelectedEvent 1090 * @param {boolean=} supressSelectedEvent
1091 */ 1091 */
1092 select(supressSelectedEvent) { 1092 select(supressSelectedEvent) {
1093 if (this.expanded) { 1093 if (this.expanded) {
1094 this.collapse(); 1094 this.collapse();
1095 return; 1095 return;
1096 } 1096 }
1097 this.expand(); 1097 this.expand();
1098 } 1098 }
1099 }; 1099 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698