Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2876623003:
[Devtools] Added character limit on name column in devtools (Closed)
|
Created:
3 years, 7 months ago by allada Modified:
3 years, 7 months ago Reviewers:
pfeldman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Devtools] Added character limit on name column in devtools
This patch is to improve performance of network panel when a domain url
is very long we crop it in order to make scrolling not lag as much.
R=pfeldman
BUG=None
Review-Url: https://codereview.chromium.org/2876623003
Cr-Commit-Position: refs/heads/master@{#472179}
Committed: https://chromium.googlesource.com/chromium/src/+/f0a3d1dc467162b8c481fe146b86d9f938eedf20
Patch Set 1 #
Total comments: 1
Patch Set 2 : [Devtools] Added character limit on name column in devtools #Patch Set 3 : [Devtools] Added character limit on name column in devtools #Messages
Total messages: 28 (16 generated)
PTL
The CQ bit was checked by allada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I also think we had more places like that. https://codereview.chromium.org/2876623003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js (right): https://codereview.chromium.org/2876623003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js:893: cell.createTextChild(this._request.networkManager().target().decorateLabel(this._request.name()).trimMiddle(100)); trim name, not the decorated label.
The CQ bit was checked by allada@chromium.org to run a CQ dry run
PTAL
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by pfeldman@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by allada@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/2876623003/#ps40001 (title: "[Devtools] Added character limit on name column in devtools")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494957612943660,
"parent_rev": "3573e1fcb10702a8d842cef0ca9ff2825a4c85db", "commit_rev":
"f0a3d1dc467162b8c481fe146b86d9f938eedf20"}
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Added character limit on name column in devtools This patch is to improve performance of network panel when a domain url is very long we crop it in order to make scrolling not lag as much. R=pfeldman BUG=None ========== to ========== [Devtools] Added character limit on name column in devtools This patch is to improve performance of network panel when a domain url is very long we crop it in order to make scrolling not lag as much. R=pfeldman BUG=None Review-Url: https://codereview.chromium.org/2876623003 Cr-Commit-Position: refs/heads/master@{#472179} Committed: https://chromium.googlesource.com/chromium/src/+/f0a3d1dc467162b8c481fe146b86... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f0a3d1dc467162b8c481fe146b86... |
