base: remove FreeBSD port of platform_thread.h

base: remove FreeBSD port of platform_thread.h

It's unused and not referenced from any .gn files, they can keep
this file as downstream diff or or upstream their diff to us.

BUG=661774
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2876623002
Cr-Commit-Position: refs/heads/master@{#470704}
Committed: https://chromium.googlesource.com/chromium/src/+/2be088539a91154a02f4fecb27f03778cca772e1

[tfarina, 2017-05-10 18:57:20]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 18:58:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-05-10 19:01:36]

lgtm

The "no bot coverage" bit is irrelevant. But it's unused and not referenced from
any .gn files, which suggests that this file either isn't needed on bsd, or that
the bsd build has been busted for a year now. In either case, removing this
seems fine.

[wychen, 2017-05-10 19:12:42]

wychen@chromium.org changed reviewers:
+ wychen@chromium.org

[wychen, 2017-05-10 19:12:42]

Looks like it's used as of M58.
https://github.com/gliaskos/freebsd-chromium/search?utf8=%E2%9C%93&q=platform...

There are lots of local patches in their repo:
https://github.com/gliaskos/freebsd-chromium/tree/master/www/chromium/files

According to https://wiki.freebsd.org/Chromium, the upstreaming effort seems
paused for quite a while.

[commit-bot: I haz the power, 2017-05-10 19:17:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:17:53]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-05-10 19:21:38]

They can keep this file as downstream diff, or upstream their diff to
base/BUILD.gn. We need to be able to make decisions which files are
actually referenced by looking at our repo.

On Wed, May 10, 2017 at 3:12 PM, <wychen@chromium.org> wrote:

> Looks like it's used as of M58.
> https://github.com/gliaskos/freebsd-chromium/search?utf8=%
> E2%9C%93&q=platform_thread_freebsd.cc&type=
>
> There are lots of local patches in their repo:
> https://github.com/gliaskos/freebsd-chromium/tree/master/
> www/chromium/files
>
> According to https://wiki.freebsd.org/Chromium, the upstreaming effort
> seems
> paused for quite a while.
>
> https://codereview.chromium.org/2876623002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2017-05-10 20:54:57]

Description was changed from

==========
base: remove FreeBSD port of platform_thread.h

We don't have bot coverage for FreeBSD and this file seems to be unused.

BUG=661774
R=thakis@chromium.org
==========

to

==========
base: remove FreeBSD port of platform_thread.h

It's unused and not referenced from any .gn files, they can keep
this file as downstream diff or or upstream their diff to us.

BUG=661774
R=thakis@chromium.org
==========

[tfarina, 2017-05-10 20:55:15]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2017-05-10 20:56:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 21:05:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494449715266860, "parent_rev":
"5fa8d94b746048527041ad5d0e8a4c11f90cb597", "commit_rev":
"2be088539a91154a02f4fecb27f03778cca772e1"}

[commit-bot: I haz the power, 2017-05-10 21:08:00]

Description was changed from

==========
base: remove FreeBSD port of platform_thread.h

It's unused and not referenced from any .gn files, they can keep
this file as downstream diff or or upstream their diff to us.

BUG=661774
R=thakis@chromium.org
==========

to

==========
base: remove FreeBSD port of platform_thread.h

It's unused and not referenced from any .gn files, they can keep
this file as downstream diff or or upstream their diff to us.

BUG=661774
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2876623002
Cr-Commit-Position: refs/heads/master@{#470704}
Committed:
https://chromium.googlesource.com/chromium/src/+/2be088539a91154a02f4fecb27f0...
==========

[commit-bot: I haz the power, 2017-05-10 21:08:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2be088539a91154a02f4fecb27f0...