Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2038)

Issue 2876593002: Change SharedMemory to initialize member vars in header. (Closed)

Created:
3 years, 7 months ago by Alexei Svitkine (slow)
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, danakj+watch_chromium.org, mac-reviews_chromium.org, gavinp+memory_chromium.org, vmpstr+watch_chromium.org, erikchen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change SharedMemory to initialize member vars in header. Also fixes some weird indentation and changes a wstring field/param to string16, since the former triggers a presubmit warning. This is a clean up with no functional changes that I'm landing ahead of: https://codereview.chromium.org/2872503003/ BUG=703649 Review-Url: https://codereview.chromium.org/2876593002 Cr-Commit-Position: refs/heads/master@{#470682} Committed: https://chromium.googlesource.com/chromium/src/+/182427f7777cd8173f248d89ae18f8b44a94794e

Patch Set 1 #

Patch Set 2 : wstring -> string16 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -47 lines) Patch
M base/memory/shared_memory.h View 1 4 chunks +9 lines, -9 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M base/memory/shared_memory_posix.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M base/memory/shared_memory_win.cc View 1 1 chunk +4 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Alexei Svitkine (slow)
3 years, 7 months ago (2017-05-10 16:22:37 UTC) #6
Nico
lgtm, thanks!
3 years, 7 months ago (2017-05-10 16:25:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876593002/20001
3 years, 7 months ago (2017-05-10 16:28:02 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 20:06:35 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/182427f7777cd8173f248d89ae18...

Powered by Google App Engine
This is Rietveld 408576698