Do not flush main thread tasks in ~ScopedTaskEnvironment.

Do not flush main thread tasks in ~ScopedTaskEnvironment.

Flushing main thread tasks in ~ScopedTaskEnvironment prevents
MessageLoop from being replaced with ScopedTaskEnvironment in v8
tests that don't expect tasks to run without an explicit call to
RunLoop::Run/RunUntilIdle.

BUG=708584
Review-Url: https://codereview.chromium.org/2876583002
Cr-Commit-Position: refs/heads/master@{#470642}
Committed: https://chromium.googlesource.com/chromium/src/+/0839a600bb0f4266560df5d7eee73b51797df7c5

[fdoray, 2017-05-10 15:29:15]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2017-05-10 15:29:30]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, robliao@chromium.org

[fdoray, 2017-05-10 15:29:30]

PTAL

[commit-bot: I haz the power, 2017-05-10 15:30:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-05-10 15:46:49]

lgtm w/ comment

https://codereview.chromium.org/2876583002/diff/1/base/test/scoped_task_envir...
File base/test/scoped_task_environment.cc (left):

https://codereview.chromium.org/2876583002/diff/1/base/test/scoped_task_envir...
base/test/scoped_task_environment.cc:58: RunLoop().RunUntilIdle();
Replace with:

// Intentionally do not RunLoop().RunUntilIdle() here as this simulates the
replaced base::~MessageLoop() behaviour better.

[fdoray, 2017-05-10 16:01:32]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2017-05-10 16:01:46]

https://codereview.chromium.org/2876583002/diff/1/base/test/scoped_task_envir...
File base/test/scoped_task_environment.cc (left):

https://codereview.chromium.org/2876583002/diff/1/base/test/scoped_task_envir...
base/test/scoped_task_environment.cc:58: RunLoop().RunUntilIdle();
On 2017/05/10 15:46:49, gab wrote:
> Replace with:
> 
> // Intentionally do not RunLoop().RunUntilIdle() here as this simulates the
> replaced base::~MessageLoop() behaviour better.

Done.

[fdoray, 2017-05-10 16:01:57]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2017-05-10 16:01:59]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-05-10 16:02:00]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2876583002/#ps20001
(title: "CR-gab-5-add-comment")

[commit-bot: I haz the power, 2017-05-10 16:03:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 18:05:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494432119793950,
"parent_rev": "bf3edb98a3b2787fcf36198f9fe9e5600db95dba", "commit_rev":
"0839a600bb0f4266560df5d7eee73b51797df7c5"}

[commit-bot: I haz the power, 2017-05-10 18:05:53]

Description was changed from

==========
Do not flush main thread tasks in ~ScopedTaskEnvironment.

Flushing main thread tasks in ~ScopedTaskEnvironment prevents
MessageLoop from being replaced with ScopedTaskEnvironment in v8
tests that don't expect tasks to run without an explicit call to
RunLoop::Run/RunUntilIdle.

BUG=708584
==========

to

==========
Do not flush main thread tasks in ~ScopedTaskEnvironment.

Flushing main thread tasks in ~ScopedTaskEnvironment prevents
MessageLoop from being replaced with ScopedTaskEnvironment in v8
tests that don't expect tasks to run without an explicit call to
RunLoop::Run/RunUntilIdle.

BUG=708584

Review-Url: https://codereview.chromium.org/2876583002
Cr-Commit-Position: refs/heads/master@{#470642}
Committed:
https://chromium.googlesource.com/chromium/src/+/0839a600bb0f4266560df5d7eee7...
==========

[commit-bot: I haz the power, 2017-05-10 18:05:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0839a600bb0f4266560df5d7eee7...