Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2876583002: Do not flush main thread tasks in ~ScopedTaskEnvironment. (Closed)

Created:
1 year, 10 months ago by fdoray
Modified:
1 year, 10 months ago
Reviewers:
robliao, gab
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not flush main thread tasks in ~ScopedTaskEnvironment. Flushing main thread tasks in ~ScopedTaskEnvironment prevents MessageLoop from being replaced with ScopedTaskEnvironment in v8 tests that don't expect tasks to run without an explicit call to RunLoop::Run/RunUntilIdle. BUG=708584 Review-Url: https://codereview.chromium.org/2876583002 Cr-Commit-Position: refs/heads/master@{#470642} Committed: https://chromium.googlesource.com/chromium/src/+/0839a600bb0f4266560df5d7eee73b51797df7c5

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR-gab-5-add-comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M base/test/scoped_task_environment.h View 1 chunk +2 lines, -3 lines 0 comments Download
M base/test/scoped_task_environment.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
fdoray
PTAL
1 year, 10 months ago (2017-05-10 15:29:30 UTC) #3
gab
lgtm w/ comment https://codereview.chromium.org/2876583002/diff/1/base/test/scoped_task_environment.cc File base/test/scoped_task_environment.cc (left): https://codereview.chromium.org/2876583002/diff/1/base/test/scoped_task_environment.cc#oldcode58 base/test/scoped_task_environment.cc:58: RunLoop().RunUntilIdle(); Replace with: // Intentionally do ...
1 year, 10 months ago (2017-05-10 15:46:49 UTC) #5
fdoray
https://codereview.chromium.org/2876583002/diff/1/base/test/scoped_task_environment.cc File base/test/scoped_task_environment.cc (left): https://codereview.chromium.org/2876583002/diff/1/base/test/scoped_task_environment.cc#oldcode58 base/test/scoped_task_environment.cc:58: RunLoop().RunUntilIdle(); On 2017/05/10 15:46:49, gab wrote: > Replace with: ...
1 year, 10 months ago (2017-05-10 16:01:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876583002/20001
1 year, 10 months ago (2017-05-10 16:03:07 UTC) #11
commit-bot: I haz the power
1 year, 10 months ago (2017-05-10 18:05:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0839a600bb0f4266560df5d7eee7...

Powered by Google App Engine
This is Rietveld 408576698