Schedule posttask to decide Uma optin option offering

chrome/browser/ui/startup/startup_browser_creator_impl.cc

Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
index 9ea079f53d99aac2954565d3968c24ca1fd45c72..58feee19bf66e8693c3e579d3809e84123bd8e3a 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
@@ -845,7 +845,8 @@ void StartupBrowserCreatorImpl::AddInfoBarsIfNecessary(
     return;
 
   if (HasPendingUncleanExit(browser->profile())) {
-    if (!command_line_.HasSwitch(switches::kEnableSessionCrashedBubble) ||
+    if (!CommandLine::ForCurrentProcess()->HasSwitch(

[Alexei Svitkine (slow), 2014/05/14 14:09:57]

Is there a reason you're changing this part?

[yao, 2014/05/14 14:53:28]

yes,
In the situation where there are multiple profiles (say 3) and but only 2
profiles were open when the browser crashes. Then when the browser is opened
again, only those 2 profiles are opened automatically. At this time, if
switching to the 3rd profile, the info bar is shown in stead of the bubble. 

The reason for this was, command_line_.HasSwitch() returns false but
CommandLine::ForCurrentProcess()->HasSwitch returns True on the same key. 

I didn't find the exact reason for this, but I know this solves the problem. 

[Alexei Svitkine (slow), 2014/05/14 15:02:54]

That's very surprising. Can you do a little investigating as to why they're
different? (i.e. where does command_line_ come from?)

If your change is indeed what we want to do to fix this, then it should have a
comment explaining why |command_line_| isn't being used, else someone will just
"clean up the code" and break it again.

[yao, 2014/05/14 21:00:26]

I believe here is the cause:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pro...

It seems to me that they just pass in an empty CommandLine object. 

I added a comment to state that command_line_ can't be used here. 

+            switches::kEnableSessionCrashedBubble) ||
         !ShowSessionCrashedBubble(browser))
       SessionCrashedInfoBarDelegate::Create(browser);
   }