Schedule posttask to decide Uma optin option offering

chrome/browser/ui/startup/startup_browser_creator_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/startup/startup_browser_creator_impl.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "apps/app_restore_service.h"
@@ skipping 827 matching lines @@
   return browser;
 }
 
 void StartupBrowserCreatorImpl::AddInfoBarsIfNecessary(
     Browser* browser,
     chrome::startup::IsProcessStartup is_process_startup) {
   if (!browser || !profile_ || browser->tab_strip_model()->count() == 0)
     return;
 
   if (HasPendingUncleanExit(browser->profile())) {
-    if (!command_line_.HasSwitch(switches::kEnableSessionCrashedBubble) ||
+    if (!CommandLine::ForCurrentProcess()->HasSwitch(

[Alexei Svitkine (slow), 2014/05/14 14:09:57]

Is there a reason you're changing this part?

[yao, 2014/05/14 14:53:28]

yes,
In the situation where there are multiple profiles (say 3) and but only 2
profiles were open when the browser crashes. Then when the browser is opened
again, only those 2 profiles are opened automatically. At this time, if
switching to the 3rd profile, the info bar is shown in stead of the bubble. 

The reason for this was, command_line_.HasSwitch() returns false but
CommandLine::ForCurrentProcess()->HasSwitch returns True on the same key. 

I didn't find the exact reason for this, but I know this solves the problem. 

[Alexei Svitkine (slow), 2014/05/14 15:02:54]

That's very surprising. Can you do a little investigating as to why they're
different? (i.e. where does command_line_ come from?)

If your change is indeed what we want to do to fix this, then it should have a
comment explaining why |command_line_| isn't being used, else someone will just
"clean up the code" and break it again.

[yao, 2014/05/14 21:00:26]

I believe here is the cause:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pro...

It seems to me that they just pass in an empty CommandLine object. 

I added a comment to state that command_line_ can't be used here. 

+            switches::kEnableSessionCrashedBubble) ||
         !ShowSessionCrashedBubble(browser))
       SessionCrashedInfoBarDelegate::Create(browser);
   }
 
   // The below info bars are only added to the first profile which is launched.
   // Other profiles might be restoring the browsing sessions asynchronously,
   // so we cannot add the info bars to the focused tabs here.
   if (is_process_startup == chrome::startup::IS_PROCESS_STARTUP &&
       !command_line_.HasSwitch(switches::kTestType)) {
     chrome::ShowBadFlagsPrompt(browser);
@@ skipping 74 matching lines @@
       // If the first URL is the NTP, replace it with the sync promo. This
       // behavior is desired because completing or skipping the sync promo
       // causes a redirect to the NTP.
       if (!startup_urls->empty() && IsNewTabURL(profile_, startup_urls->at(0)))
         startup_urls->at(0) = sync_promo_url;
       else
         startup_urls->insert(startup_urls->begin(), sync_promo_url);
     }
   }
 }