Schedule posttask to decide Uma optin option offering

chrome/browser/ui/views/session_crashed_bubble_view.h

Index: chrome/browser/ui/views/session_crashed_bubble_view.h
diff --git a/chrome/browser/ui/views/session_crashed_bubble_view.h b/chrome/browser/ui/views/session_crashed_bubble_view.h
index 8986da6c983bff5b01a1727d9b83bd3db93ab84b..3dbedadfe1be6f7e47e10de01bd11c701e85e251 100644
--- a/chrome/browser/ui/views/session_crashed_bubble_view.h
+++ b/chrome/browser/ui/views/session_crashed_bubble_view.h
@@ -38,14 +38,21 @@ class SessionCrashedBubbleView
       public content::NotificationObserver,
       public TabStripModelObserver {
  public:
+  // Schedule a posttask to find out whether or not uma optin option should be
+  // offered. After it finishes, calls ShowForReal to show the bubble.

[Alexei Svitkine (slow), 2014/05/14 21:17:02]

Nit: This comment is talking about an implementation detail of the function, so
shouldn't be in the docs on the public function.

[yao, 2014/05/14 21:24:31]

Done.

   static void Show(Browser* browser);
 
  private:
   SessionCrashedBubbleView(views::View* anchor_view,
                            Browser* browser,
-                           content::WebContents* web_contents);
+                           content::WebContents* web_contents,
+                           bool offer_uma_optin);
   virtual ~SessionCrashedBubbleView();
 
+  // Called by Show(Browser* browser) after knowing whether or not uma optin
+  // option should be offered, it creates and shows the session crashed bubble.

[Alexei Svitkine (slow), 2014/05/14 21:17:02]

Nit: Seems like you have two sentences jammed together - i.e. "Called after x"
and "After x, it creates."

how about:

  // Creates and shows the session crashed bubble, with |offer_uma_optin|
  // indicating whether the UMA opt-in checkbox should be shown. Called
  // by Show() after checking whether the UMA option should be presented.

[yao, 2014/05/14 21:24:31]

Done.

+  static void ShowForReal(Browser* browser, bool offer_uma_optin);
+
   // WidgetDelegateView methods.
   virtual views::View* GetInitiallyFocusedView() OVERRIDE;
 
@@ -112,6 +119,9 @@ class SessionCrashedBubbleView
   // Checkbox for the user to opt-in to UMA reporting.
   views::Checkbox* uma_option_;
 
+  // Whether or not should offer UMA opt-in option.

[Alexei Svitkine (slow), 2014/05/14 21:17:02]

Nit: "Whether or not the UMA opt-in option should be shown."

[yao, 2014/05/14 21:24:31]

Done.

+  bool offer_uma_optin_;
+
   // Whether or not a navigation has started on current tab.
   bool started_navigation_;