Schedule posttask to decide Uma optin option offering

chrome/browser/ui/views/session_crashed_bubble_view.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_SESSION_CRASHED_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_SESSION_CRASHED_BUBBLE_VIEW_H_
 
 #include "chrome/browser/ui/tabs/tab_strip_model_observer.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
@@ skipping 20 matching lines @@
 // crashed. It also presents an option to enable metrics reporting, if it not
 // enabled already.
 class SessionCrashedBubbleView
     : public views::BubbleDelegateView,
       public views::ButtonListener,
       public views::StyledLabelListener,
       public content::WebContentsObserver,
       public content::NotificationObserver,
       public TabStripModelObserver {
  public:
+  // Schedule a posttask to find out whether or not uma optin option should be
+  // offered. After it finishes, calls ShowForReal to show the bubble.

[Alexei Svitkine (slow), 2014/05/14 21:17:02]

Nit: This comment is talking about an implementation detail of the function, so
shouldn't be in the docs on the public function.

[yao, 2014/05/14 21:24:31]

Done.

   static void Show(Browser* browser);
 
  private:
   SessionCrashedBubbleView(views::View* anchor_view,
                            Browser* browser,
-                           content::WebContents* web_contents);
+                           content::WebContents* web_contents,
+                           bool offer_uma_optin);
   virtual ~SessionCrashedBubbleView();
 
+  // Called by Show(Browser* browser) after knowing whether or not uma optin
+  // option should be offered, it creates and shows the session crashed bubble.

[Alexei Svitkine (slow), 2014/05/14 21:17:02]

Nit: Seems like you have two sentences jammed together - i.e. "Called after x"
and "After x, it creates."

how about:

  // Creates and shows the session crashed bubble, with |offer_uma_optin|
  // indicating whether the UMA opt-in checkbox should be shown. Called
  // by Show() after checking whether the UMA option should be presented.

[yao, 2014/05/14 21:24:31]

Done.

+  static void ShowForReal(Browser* browser, bool offer_uma_optin);
+
   // WidgetDelegateView methods.
   virtual views::View* GetInitiallyFocusedView() OVERRIDE;
 
   // views::BubbleDelegateView methods.
   virtual void Init() OVERRIDE;
 
   // views::ButtonListener methods.
   virtual void ButtonPressed(views::Button* sender,
                              const ui::Event& event) OVERRIDE;
 
@@ skipping 46 matching lines @@
 
   // Button for the user to confirm a session restore.
   views::LabelButton* restore_button_;
 
   // Button for the user to close this bubble.
   views::LabelButton* close_;
 
   // Checkbox for the user to opt-in to UMA reporting.
   views::Checkbox* uma_option_;
 
+  // Whether or not should offer UMA opt-in option.

[Alexei Svitkine (slow), 2014/05/14 21:17:02]

Nit: "Whether or not the UMA opt-in option should be shown."

[yao, 2014/05/14 21:24:31]

Done.

+  bool offer_uma_optin_;
+
   // Whether or not a navigation has started on current tab.
   bool started_navigation_;
 
   DISALLOW_COPY_AND_ASSIGN(SessionCrashedBubbleView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_SESSION_CRASHED_BUBBLE_VIEW_H_