Get rid of two callsites of effect_tree.FindNodeIndexFromOwningLayerId.

Get rid of two callsites of effect_tree.FindNodeIndexFromOwningLayerId.

BUG=718564
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2876473005
Cr-Commit-Position: refs/heads/master@{#471112}
Committed: https://chromium.googlesource.com/chromium/src/+/5f60ca0996ee808f6479a89ea74c665888b41bfd

[chrishtr, 2017-05-11 19:59:03]

Description was changed from

==========
none


none


none


none


none

BUG=
==========

to

==========
none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chrishtr, 2017-05-11 20:05:13]

Description was changed from

==========
none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Update cc unittests to be closer to getting rid of owning layer from effects.

BUG=718564
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chrishtr, 2017-05-11 20:05:53]

Description was changed from

==========
Update cc unittests to be closer to getting rid of owning layer from effects.

BUG=718564
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Get rid of two callsites of effect_tree.FindNodeIndexFromOwningLayerId.

BUG=718564
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[chrishtr, 2017-05-11 20:06:59]

chrishtr@chromium.org changed reviewers:
+ ajuma@chromium.org, wkorman@chromium.org

[chrishtr, 2017-05-11 20:07:00]

https://codereview.chromium.org/2876473005/diff/1/cc/test/layer_test_common.cc
File cc/test/layer_test_common.cc (right):

https://codereview.chromium.org/2876473005/diff/1/cc/test/layer_test_common.c...
cc/test/layer_test_common.cc:38: if (RenderSurfaceImpl* surface =
The old test code assumed that a layer "owned" a render surface; now it
checks for into what render surface a layer draws.

[chrishtr, 2017-05-11 20:07:05]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 20:08:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wkorman, 2017-05-11 22:09:26]

lgtm

https://codereview.chromium.org/2876473005/diff/1/cc/trees/layer_tree_host_co...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/2876473005/diff/1/cc/trees/layer_tree_host_co...
cc/trees/layer_tree_host_common_unittest.cc:881:
ASSERT_EQ(GetRenderSurface(child_of_root), GetRenderSurface(root));
Adding assert/expect helper to shorten all of these refs seems worthwhile.

Or a RenderSurfacesEqual(a, b) and then use false/true assert/expects.

[chrishtr, 2017-05-11 22:15:39]

https://codereview.chromium.org/2876473005/diff/1/cc/test/layer_test_common.cc
File cc/test/layer_test_common.cc (right):

https://codereview.chromium.org/2876473005/diff/1/cc/test/layer_test_common.c...
cc/test/layer_test_common.cc:38: if (RenderSurfaceImpl* surface =
On 2017/05/11 at 20:07:00, chrishtr wrote:
> The old test code assumed that a layer "owned" a render surface; now it
> checks for into what render surface a layer draws.

Right.

https://codereview.chromium.org/2876473005/diff/1/cc/trees/layer_tree_host_co...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/2876473005/diff/1/cc/trees/layer_tree_host_co...
cc/trees/layer_tree_host_common_unittest.cc:881:
ASSERT_EQ(GetRenderSurface(child_of_root), GetRenderSurface(root));
On 2017/05/11 at 22:09:26, wkorman wrote:
> Adding assert/expect helper to shorten all of these refs seems worthwhile.
> 
> Or a RenderSurfacesEqual(a, b) and then use false/true assert/expects.

Per offline discussion, will just leave it.

[chrishtr, 2017-05-11 22:15:42]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-05-11 22:15:44]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-05-11 22:16:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 23:09:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494540944125810, "parent_rev":
"e56e395b65eb473d5f0814a8e870e75632c76229", "commit_rev":
"5f60ca0996ee808f6479a89ea74c665888b41bfd"}

[commit-bot: I haz the power, 2017-05-11 23:10:07]

Description was changed from

==========
Get rid of two callsites of effect_tree.FindNodeIndexFromOwningLayerId.

BUG=718564
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Get rid of two callsites of effect_tree.FindNodeIndexFromOwningLayerId.

BUG=718564
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2876473005
Cr-Commit-Position: refs/heads/master@{#471112}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f60ca0996ee808f6479a89ea74c...
==========

[commit-bot: I haz the power, 2017-05-11 23:10:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5f60ca0996ee808f6479a89ea74c...