Read WebUSB landing page even if allowed origin read fails

Read WebUSB landing page even if allowed origin read fails

Now that support for the GET_ALLOWED_ORIGINS request is optional WebUSB
devices may only support the GET_URL request used for reading the
landing page from the device. This patch fixes the descriptor reading
logic so that this is supported.

(Note, the logic to send the GET_ALLOWED_ORIGINS request will be removed
entirely as part of issue 711443.)

BUG=721546
Review-Url: https://codereview.chromium.org/2876463008
Cr-Commit-Position: refs/heads/master@{#471141}
Committed: https://chromium.googlesource.com/chromium/src/+/84869d699fe82560ca9ac3f30c5b959110af30bf

[Reilly Grant (use Gerrit), 2017-05-11 22:06:32]

reillyg@chromium.org changed reviewers:
+ mcasas@chromium.org

[Reilly Grant (use Gerrit), 2017-05-11 22:06:32]

PTAL

[mcasas, 2017-05-11 22:23:40]

lgtm

https://codereview.chromium.org/2876463008/diff/1/device/usb/webusb_descripto...
File device/usb/webusb_descriptors.cc (right):

https://codereview.chromium.org/2876463008/diff/1/device/usb/webusb_descripto...
device/usb/webusb_descriptors.cc:228: // with the GURLs matching the indicies
already collected.
s/indicies/indexes/  or s/indicies/indices/

[Reilly Grant (use Gerrit), 2017-05-11 22:31:30]

s/indicies/indices/

[Reilly Grant (use Gerrit), 2017-05-11 22:31:51]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-05-11 22:31:51]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2876463008/#ps20001
(title: "s/indicies/indices/")

[commit-bot: I haz the power, 2017-05-11 22:32:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 00:24:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494541911139220,
"parent_rev": "19776ea6b20f56507e080f09a8b508c3ec6ba5be", "commit_rev":
"84869d699fe82560ca9ac3f30c5b959110af30bf"}

[commit-bot: I haz the power, 2017-05-12 00:24:52]

Description was changed from

==========
Read WebUSB landing page even if allowed origin read fails

Now that support for the GET_ALLOWED_ORIGINS request is optional WebUSB
devices may only support the GET_URL request used for reading the
landing page from the device. This patch fixes the descriptor reading
logic so that this is supported.

(Note, the logic to send the GET_ALLOWED_ORIGINS request will be removed
entirely as part of issue 711443.)

BUG=721546
==========

to

==========
Read WebUSB landing page even if allowed origin read fails

Now that support for the GET_ALLOWED_ORIGINS request is optional WebUSB
devices may only support the GET_URL request used for reading the
landing page from the device. This patch fixes the descriptor reading
logic so that this is supported.

(Note, the logic to send the GET_ALLOWED_ORIGINS request will be removed
entirely as part of issue 711443.)

BUG=721546

Review-Url: https://codereview.chromium.org/2876463008
Cr-Commit-Position: refs/heads/master@{#471141}
Committed:
https://chromium.googlesource.com/chromium/src/+/84869d699fe82560ca9ac3f30c5b...
==========

[commit-bot: I haz the power, 2017-05-12 00:24:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/84869d699fe82560ca9ac3f30c5b...