Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2876463007: Revert of Make ProfileIOData's ProxyService fetch PACs with the main URLRequestContext (Closed)

Created:
3 years, 7 months ago by mmenke
Modified:
3 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make ProfileIOData's ProxyService fetch PACs with the main URLRequestContext (patchset #11 id:340001 of https://codereview.chromium.org/2841163002/ ) Reason for revert: This ran into a race with extension setup. Have a CL out to fix that, but reverting this in the meantime. I'll plan to TBR the reland, since this bug this tickled has no real relation to any code in this CL, but is a pre-existing issue in other code that this tickled. Original issue's description: > Make ProfileIOData's ProxyService fetch PACs with the main URLRequestContext. > > This is intended to make servicification a little simpler, since we won't > have to configure a secret global URLRequestContext used just to fetch PAC > scripts. > > The system URLRequestContext will be updated in a similar manner in a > followup CL. > > BUG=715697 > > Review-Url: https://codereview.chromium.org/2841163002 > Cr-Commit-Position: refs/heads/master@{#469044} > Committed: https://chromium.googlesource.com/chromium/src/+/0a8ca0d1e3ac86cd1d0955fc66a43aaa1eaf7393 TBR=eroman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=715697

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -174 lines) Patch
M chrome/browser/net/proxy_browsertest.cc View 3 chunks +0 lines, -95 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.h View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 3 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 6 chunks +16 lines, -41 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
mmenke
Created Revert of Make ProfileIOData's ProxyService fetch PACs with the main URLRequestContext
3 years, 7 months ago (2017-05-11 15:49:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876463007/1
3 years, 7 months ago (2017-05-11 15:49:56 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/265987) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 7 months ago (2017-05-11 15:54:26 UTC) #5
mmenke
3 years, 7 months ago (2017-05-12 18:22:49 UTC) #6
Seems too late to bother landing this now - hope to get a fix in on Monday.

Powered by Google App Engine
This is Rietveld 408576698