Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2876463006: Allow an arbitrary number of cookie string pairs. (Closed)

Created:
3 years, 7 months ago by Mike West
Modified:
3 years, 7 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow an arbitrary number of cookie string pairs. Currently, we limit cookie parsing to 16 attribute pairs. Other browsers don't impose this limit, and we can increase interoperability (for weird things like `a=b;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;secure`) by dropping it. So, let's do so. BUG=711505 Review-Url: https://codereview.chromium.org/2876463006 Cr-Commit-Position: refs/heads/master@{#471720} Committed: https://chromium.googlesource.com/chromium/src/+/badf4bfd210beb80863554d5ddb8853b90124d06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M net/cookies/parsed_cookie.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/cookies/parsed_cookie.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/parsed_cookie_unittest.cc View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Mike West
Hey, Jochen. Care to use your new AMAZING REVIEW EVERYTHING OMG powers to take a ...
3 years, 7 months ago (2017-05-11 08:57:36 UTC) #4
Mike West
Ping. :)
3 years, 7 months ago (2017-05-12 08:20:18 UTC) #7
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-12 08:30:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876463006/1
3 years, 7 months ago (2017-05-12 09:22:52 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/382981)
3 years, 7 months ago (2017-05-12 10:06:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876463006/1
3 years, 7 months ago (2017-05-15 07:36:22 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/444250)
3 years, 7 months ago (2017-05-15 09:39:56 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876463006/1
3 years, 7 months ago (2017-05-15 09:40:34 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 10:49:35 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/badf4bfd210beb80863554d5ddb8...

Powered by Google App Engine
This is Rietveld 408576698