Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2876463003: color: Add unit test to ensure sRGB SkColorSpaces match (Closed)

Created:
3 years, 7 months ago by ccameron
Modified:
3 years, 7 months ago
Reviewers:
hubbe
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Add unit test to ensure sRGB SkColorSpaces match It turns out that Skia does fuzzy comparision for gamma and gamut internally. Add tests to be emphatic about this, since we don't want to promote layers to non-sRGB rendering just because they have an image that is tagged with an sRGB color space. BUG=719735 Review-Url: https://codereview.chromium.org/2876463003 Cr-Commit-Position: refs/heads/master@{#470671} Committed: https://chromium.googlesource.com/chromium/src/+/fa21c64f46ed363641a70bc230afbe21fd10c0e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M ui/gfx/icc_profile_unittest.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
ccameron
There's still a TODO for this in gfx::ColorSpace, which we should eventually get to (the ...
3 years, 7 months ago (2017-05-10 14:08:55 UTC) #2
hubbe
lgtm
3 years, 7 months ago (2017-05-10 17:36:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876463003/1
3 years, 7 months ago (2017-05-10 18:56:19 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 19:38:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fa21c64f46ed363641a70bc230af...

Powered by Google App Engine
This is Rietveld 408576698