Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2876393002: Clean up duplicate Page methods (Closed)

Created:
3 years, 7 months ago by sashab
Modified:
3 years, 6 months ago
Reviewers:
slangley, dcheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up duplicate Page methods BUG=691794

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -48 lines) Patch
M third_party/WebKit/Source/core/page/Page.h View 1 chunk +6 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 2 chunks +6 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
sashab
3 years, 7 months ago (2017-05-15 06:04:49 UTC) #3
dcheng
Hmm.... so the reason we have these is for const-correctness. There seems to have been ...
3 years, 7 months ago (2017-05-15 06:08:24 UTC) #5
sashab
3 years, 6 months ago (2017-05-30 04:07:29 UTC) #9
Abandoning patch; as per discussion on cxx@chromium.org, this work should
require careful refactoring to achieve "const okay"-ness.

NB: Changing the methods to "const Foo& GetFoo() const" results in many compile
errors.

Powered by Google App Engine
This is Rietveld 408576698