Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2876373002: Change reinterpret_cast to std::copy to avoid undefined behavior (Closed)

Created:
3 years, 7 months ago by sabbakumov
Modified:
3 years, 7 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change reinterpret_cast to std::copy to avoid undefined behavior It seems like the reinterpret_cast is not valid here and should be changed to std::copy or memcpy. Probably dereferencing the given pointer is undefined behavior: http://en.cppreference.com/w/cpp/language/reinterpret_cast BUG=722170 Review-Url: https://codereview.chromium.org/2876373002 Cr-Commit-Position: refs/heads/master@{#472717} Committed: https://chromium.googlesource.com/chromium/src/+/88b9bc14b5d592e258623f27363d768ec25ce05b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/metrics/antivirus_metrics_provider_win.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sabbakumov
3 years, 7 months ago (2017-05-15 04:32:15 UTC) #3
rkaplow
lgtm
3 years, 7 months ago (2017-05-17 14:11:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876373002/1
3 years, 7 months ago (2017-05-18 02:58:50 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 07:00:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/88b9bc14b5d592e258623f27363d...

Powered by Google App Engine
This is Rietveld 408576698