Make for statements using C++11 foreach in LayoutSelection::SetSelection()

Make for loop using C++11 foreach in LayoutSelection::SetSelection()

BUG=708453
Review-Url: https://codereview.chromium.org/2876363002
Cr-Commit-Position: refs/heads/master@{#471977}
Committed: https://chromium.googlesource.com/chromium/src/+/56fd91872a4109611d4c1142243b349e430b61a2

[yoichio, 2017-05-15 04:22:57]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 04:23:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-05-15 04:23:25]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2017-05-15 07:05:09]

https://codereview.chromium.org/2876363002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/LayoutSelection.cpp (right):

https://codereview.chromium.org/2876363002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/LayoutSelection.cpp:223: for (const auto&
it : old_selected_map.object_map)
nit: s/it/key_value/ or s/it/layout_object_and_selection_state/

Using |it| is confusing, since |it| is used for iterator.

range-for is short-form of

for (auto it = map.begin(); it != map.end(); ++it) {
  const auto& key_value = *it;
  ...
}

[commit-bot: I haz the power, 2017-05-15 07:46:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 07:46:22]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-05-15 07:59:43]

https://codereview.chromium.org/2876363002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/LayoutSelection.cpp (right):

https://codereview.chromium.org/2876363002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/LayoutSelection.cpp:223: for (const auto&
it : old_selected_map.object_map)
On 2017/05/15 07:05:09, yosin_UTC9 wrote:
> nit: s/it/key_value/ or s/it/layout_object_and_selection_state/
> 
> Using |it| is confusing, since |it| is used for iterator.
> 
> range-for is short-form of
> 
> for (auto it = map.begin(); it != map.end(); ++it) {
>   const auto& key_value = *it;
>   ...
> }

Done.

[yoichio, 2017-05-15 07:59:51]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 08:00:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-05-15 08:23:12]

lgtm

[hugoh_UTC2, 2017-05-15 09:23:06]

Nice readability improvement! :)

[commit-bot: I haz the power, 2017-05-15 09:40:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 09:40:48]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-05-16 01:33:22]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2017-05-16 01:34:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 01:47:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494898402369780,
"parent_rev": "9847aeaf079339c729859157552eabde17ae3b17", "commit_rev":
"56fd91872a4109611d4c1142243b349e430b61a2"}

[commit-bot: I haz the power, 2017-05-16 01:47:33]

Description was changed from

==========
Make for loop using C++11 foreach in LayoutSelection::SetSelection()

BUG=708453
==========

to

==========
Make for loop using C++11 foreach in LayoutSelection::SetSelection()

BUG=708453

Review-Url: https://codereview.chromium.org/2876363002
Cr-Commit-Position: refs/heads/master@{#471977}
Committed:
https://chromium.googlesource.com/chromium/src/+/56fd91872a4109611d4c1142243b...
==========

[commit-bot: I haz the power, 2017-05-16 01:47:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/56fd91872a4109611d4c1142243b...