Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2876343002: Fix the main profile button avatar having too much padding. (Closed)

Created:
3 years, 7 months ago by Bret
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the main profile button avatar having too much padding. Before I landed crrev.com/2859193004 GridLayout didn't take into account the view's border. The main profile button was adding its own padding to account for that problem. After that patch landed it meant it was doubly-padded. This patch removes the extra padding. BUG=721660 Review-Url: https://codereview.chromium.org/2876343002 Cr-Commit-Position: refs/heads/master@{#472211} Committed: https://chromium.googlesource.com/chromium/src/+/2d5a6e2316c416cd9e012430dd473fe1fadc953d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Bret
3 years, 7 months ago (2017-05-14 01:52:39 UTC) #5
sky
LGTM
3 years, 7 months ago (2017-05-15 15:35:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876343002/1
3 years, 7 months ago (2017-05-16 18:24:20 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 20:43:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d5a6e2316c416cd9e012430dd47...

Powered by Google App Engine
This is Rietveld 408576698