Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2876313002:
Include the mode switch when elevating to register Chrome. (Closed)
|
Created:
3 years, 7 months ago by grt (UTC plus 2) Modified:
3 years, 7 months ago Reviewers:
manzagop (departed) CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionInclude the mode switch when elevating to register Chrome.
On Windows 7, per-user Chrome must run the installer elevated to
register as an eligible browser. It must use the proper mode switch when
doing so in order for the installer to make the proper registrations.
BUG=373987
Review-Url: https://codereview.chromium.org/2876313002
Cr-Commit-Position: refs/heads/master@{#472454}
Committed: https://chromium.googlesource.com/chromium/src/+/3dec17ff35f5a9081b098da11fdd05cfcc508c92
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
Description was changed from ========== Include the mode switch when elevating to register Chrome. On Windows 7, per-user Chrome must run the installer elevated to register as an eligible browser. While side-by-side dev and beta should never hit this on account of not presenting default browser UX, it is best to be consistent in the code in case this policy decision ever changs. BUG=373987 ========== to ========== Include the mode switch when elevating to register Chrome. On Windows 7, per-user Chrome must run the installer elevated to register as an eligible browser. It must use the proper mode switch when doing so. BUG=373987 ==========
grt@chromium.org changed reviewers: + pmonette@chromium.org
The CQ bit was checked by grt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Include the mode switch when elevating to register Chrome. On Windows 7, per-user Chrome must run the installer elevated to register as an eligible browser. It must use the proper mode switch when doing so. BUG=373987 ========== to ========== Include the mode switch when elevating to register Chrome. On Windows 7, per-user Chrome must run the installer elevated to register as an eligible browser. It must use the proper mode switch when doing so in order for the installer to make the proper registrations. BUG=373987 ==========
grt@chromium.org changed reviewers: + manzagop@chromium.org - pmonette@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
LGTM Does something need to be changed for uninstalls?
On 2017/05/17 13:38:07, manzagop wrote: > LGTM > > Does something need to be changed for uninstalls? Not in this case. Thanks for checking.
On 2017/05/17 13:38:07, manzagop wrote: > LGTM > > Does something need to be changed for uninstalls? Not in this case. Thanks for checking.
The CQ bit was checked by grt@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495030944222140, "parent_rev":
"b8eb3b0fb31d40ea36582b582f501d6ab75a836c", "commit_rev":
"3dec17ff35f5a9081b098da11fdd05cfcc508c92"}
Message was sent while issue was closed.
Description was changed from ========== Include the mode switch when elevating to register Chrome. On Windows 7, per-user Chrome must run the installer elevated to register as an eligible browser. It must use the proper mode switch when doing so in order for the installer to make the proper registrations. BUG=373987 ========== to ========== Include the mode switch when elevating to register Chrome. On Windows 7, per-user Chrome must run the installer elevated to register as an eligible browser. It must use the proper mode switch when doing so in order for the installer to make the proper registrations. BUG=373987 Review-Url: https://codereview.chromium.org/2876313002 Cr-Commit-Position: refs/heads/master@{#472454} Committed: https://chromium.googlesource.com/chromium/src/+/3dec17ff35f5a9081b098da11fdd... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3dec17ff35f5a9081b098da11fdd... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
