Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2876303002: Revert of Image Capture: wire setPhotoOptions() for Win (Closed)

Created:
3 years, 7 months ago by mcasas
Modified:
3 years, 7 months ago
Reviewers:
robliao
CC:
chromium-reviews, msramek+watch_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, raymes+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, mfoltz+watch_chromium.org, markusheintz_, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Image Capture: wire setPhotoOptions() for Win (patchset #3 id:80001 of https://codereview.chromium.org/2873143002/ ) Reason for revert: /video_capture_device_win.obj ninja -t msvc -e environment.x86 -- C:\b\c\goma_client/gomacc.exe "C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/media/capture/capture_lib/video_capture_device_win.obj.rsp /c ../../media/capture/video/win/video_capture_device_win.cc /Foobj/media/capture/capture_lib/video_capture_device_win.obj /Fd"obj/media/capture/capture_lib_cc.pdb" c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(637): error C2220: warning treated as error - no 'object' file generated c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(637): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(644): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(654): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(661): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(670): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(676): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(681): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(686): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(691): warning C4189: 'hr': local variable is initialized but not referenced Original issue's description: > Image Capture: wire setPhotoOptions() for Win > > This CL wires the photo capabilities setPhotoOptions() method: > > - |camera_control_| and |video_control_| are made member > variables, which forces trivial updates to the lambdas. > > - most of the controls are straightforward except white > balance and exposure: those have a 'manual' and 'auto' > that enable the use of |color_temperature| and > |exposure_compensation|, resp. Since either of them can > be configured in subsequent setPhotoOptions() cycles, we need > member flags to keep the manual/auto state. > > > > BUG=657128 > > Review-Url: https://codereview.chromium.org/2873143002 > Cr-Commit-Position: refs/heads/master@{#471554} > Committed: https://chromium.googlesource.com/chromium/src/+/86adb2c88ba82194458ac09d078a00616c0b22dd TBR=robliao@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657128 Review-Url: https://codereview.chromium.org/2876303002 Cr-Commit-Position: refs/heads/master@{#471559} Committed: https://chromium.googlesource.com/chromium/src/+/cd356540e646a136d9ac96c49920b0611227fc29

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -171 lines) Patch
M media/capture/video/win/video_capture_device_win.h View 3 chunks +0 lines, -11 lines 0 comments Download
M media/capture/video/win/video_capture_device_win.cc View 6 chunks +86 lines, -160 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
mcasas
Created Revert of Image Capture: wire setPhotoOptions() for Win
3 years, 7 months ago (2017-05-13 04:16:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876303002/1
3 years, 7 months ago (2017-05-13 04:16:38 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 04:17:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd356540e646a136d9ac96c49920...

Powered by Google App Engine
This is Rietveld 408576698