Simplify FaviconHandler::OnFaviconDataForInitialURLFromFaviconService()

Simplify FaviconHandler::OnFaviconDataForInitialURLFromFaviconService()

This CL changes OnFaviconDataForInitialURLFromFaviconService() to call
NotifyFaviconUpdated() if the database has a valid bitmap for the page
URL regardless of the order that OnFaviconDataForInitialURLFromFaviconService()
and OnUpdateCandidates() were called.

Previously:
If OnFaviconDataForInitialURLFromFaviconService() is called after
OnUpdateCandidates():
  NotifyFaviconUpdated() is called from
  OnFaviconDataForInitialURLFromFaviconService() only if the icon URL in the
  database matches the <link rel="icon"> on the page.
If OnFaviconDataForInitialURLFromFaviconService() is called before
OnUpdateCandidates():
  NotifyFaviconUpdated() is called from
  OnFaviconDataForInitialURLFromFaviconService() if the database has a
  valid bitmap for the page URL.

BUG=None

Review-Url: https://codereview.chromium.org/2876263003
Cr-Commit-Position: refs/heads/master@{#471767}
Committed: https://chromium.googlesource.com/chromium/src/+/e5564e57b495715eba8c8cd12da775abc45c5db7

[pkotwicz, 2017-05-13 17:26:46]

pkotwicz@chromium.org changed reviewers:
+ mastiz@chromium.org

[pkotwicz, 2017-05-13 17:26:46]

Mikel, can you please take a look?

[mastiz, 2017-05-15 05:21:35]

LGTM!

About the CL description:
1. I'd recommend starting with the last paragraph, i.e. the one describing the
actual change.

2. In multiple places, did you mean
OnFaviconDataForInitialURLFromFaviconService() instead of
OnGotInitialHistoryDataAndIconURLCandidates()?

[pkotwicz, 2017-05-15 14:07:02]

Description was changed from

==========
Simplify FaviconHandler::OnGotInitialHistoryDataAndIconURLCandidates()

If OnGotInitialHistoryDataAndIconURLCandidates() is called after
OnUpdateCandidates():
  NotifyFaviconUpdated() is called from
  OnGotInitialHistoryDataAndIconURLCandidates() only if the icon URL in the
  database matches the <link rel="icon"> on the page.
If OnGotInitialHistoryDataAndIconURLCandidates() is called before
OnUpdateCandidates():
  NotifyFaviconUpdated() is called from
  OnGotInitialHistoryDataAndIconURLCandidates() if the database has a
  valid bitmap for the page URL.

This CL changes OnGotInitialHistoryDataAndIconURLCandidates() to call
NotifyFaviconUpdated() regardless if the database has valid bitmap for the page
URL regardless of the order that OnGotInitialHistoryDataAndIconURLCandidates()
and OnUpdateCandidates() were called.

BUG=None
==========

to

==========
Simplify FaviconHandler::OnFaviconDataForInitialURLFromFaviconService()

This CL changes OnFaviconDataForInitialURLFromFaviconService() to call
NotifyFaviconUpdated() if the database has a valid bitmap for the page
URL regardless of the order that OnFaviconDataForInitialURLFromFaviconService()
and OnUpdateCandidates() were called.

Previously:
If OnFaviconDataForInitialURLFromFaviconService() is called after
OnUpdateCandidates():
  NotifyFaviconUpdated() is called from
  OnFaviconDataForInitialURLFromFaviconService() only if the icon URL in the
  database matches the <link rel="icon"> on the page.
If OnFaviconDataForInitialURLFromFaviconService() is called before
OnUpdateCandidates():
  NotifyFaviconUpdated() is called from
  OnFaviconDataForInitialURLFromFaviconService() if the database has a
  valid bitmap for the page URL.

BUG=None
==========

[pkotwicz, 2017-05-15 14:07:28]

Updated the comments as you requested (Thanks for the catch about the function
names)

[pkotwicz, 2017-05-15 14:07:32]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2017-05-15 14:07:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 15:09:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494857252947470, "parent_rev":
"452ecc0e7cf545a650047227a7e9ce4702ed227d", "commit_rev":
"e5564e57b495715eba8c8cd12da775abc45c5db7"}

[commit-bot: I haz the power, 2017-05-15 15:09:47]

Description was changed from

==========
Simplify FaviconHandler::OnFaviconDataForInitialURLFromFaviconService()

This CL changes OnFaviconDataForInitialURLFromFaviconService() to call
NotifyFaviconUpdated() if the database has a valid bitmap for the page
URL regardless of the order that OnFaviconDataForInitialURLFromFaviconService()
and OnUpdateCandidates() were called.

Previously:
If OnFaviconDataForInitialURLFromFaviconService() is called after
OnUpdateCandidates():
  NotifyFaviconUpdated() is called from
  OnFaviconDataForInitialURLFromFaviconService() only if the icon URL in the
  database matches the <link rel="icon"> on the page.
If OnFaviconDataForInitialURLFromFaviconService() is called before
OnUpdateCandidates():
  NotifyFaviconUpdated() is called from
  OnFaviconDataForInitialURLFromFaviconService() if the database has a
  valid bitmap for the page URL.

BUG=None
==========

to

==========
Simplify FaviconHandler::OnFaviconDataForInitialURLFromFaviconService()

This CL changes OnFaviconDataForInitialURLFromFaviconService() to call
NotifyFaviconUpdated() if the database has a valid bitmap for the page
URL regardless of the order that OnFaviconDataForInitialURLFromFaviconService()
and OnUpdateCandidates() were called.

Previously:
If OnFaviconDataForInitialURLFromFaviconService() is called after
OnUpdateCandidates():
  NotifyFaviconUpdated() is called from
  OnFaviconDataForInitialURLFromFaviconService() only if the icon URL in the
  database matches the <link rel="icon"> on the page.
If OnFaviconDataForInitialURLFromFaviconService() is called before
OnUpdateCandidates():
  NotifyFaviconUpdated() is called from
  OnFaviconDataForInitialURLFromFaviconService() if the database has a
  valid bitmap for the page URL.

BUG=None

Review-Url: https://codereview.chromium.org/2876263003
Cr-Commit-Position: refs/heads/master@{#471767}
Committed:
https://chromium.googlesource.com/chromium/src/+/e5564e57b495715eba8c8cd12da7...
==========

[commit-bot: I haz the power, 2017-05-15 15:09:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e5564e57b495715eba8c8cd12da7...