Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2876243002: Add method to init HttpNetworkSession::Params from context bulder params (Closed)

Created:
3 years, 7 months ago by mmenke
Modified:
3 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add method to init HttpNetworkSession::Params from context bulder params This method will most likely be temporary, and removed once IOThread's and ProfileIOData's URLRequestContexts can be configured using a URLRequestContextBuilder. BUG=715697 Review-Url: https://codereview.chromium.org/2876243002 Cr-Commit-Position: refs/heads/master@{#471501} Committed: https://chromium.googlesource.com/chromium/src/+/cfea205a4f3ebb3f443467fe96c7252ebf375089

Patch Set 1 #

Total comments: 4

Patch Set 2 : Defrag #

Patch Set 3 : Oops, base on top of trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -34 lines) Patch
M net/url_request/url_request_context_builder.h View 1 1 chunk +7 lines, -2 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 3 chunks +32 lines, -32 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
mmenke
This is pretty much pure copy-paste. Next CL will switch the IOThread over to using ...
3 years, 7 months ago (2017-05-12 18:02:03 UTC) #5
Randy Smith (Not in Mondays)
LGTM. https://codereview.chromium.org/2876243002/diff/1/net/url_request/url_request_context_builder.cc File net/url_request/url_request_context_builder.cc (right): https://codereview.chromium.org/2876243002/diff/1/net/url_request/url_request_context_builder.cc#newcode204 net/url_request/url_request_context_builder.cc:204: network_session_params->host_mapping_rules = host_mapping_rules; Not relevant to this CL ...
3 years, 7 months ago (2017-05-12 19:43:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876243002/60001
3 years, 7 months ago (2017-05-12 20:12:54 UTC) #13
mmenke
Thanks! https://codereview.chromium.org/2876243002/diff/1/net/url_request/url_request_context_builder.cc File net/url_request/url_request_context_builder.cc (right): https://codereview.chromium.org/2876243002/diff/1/net/url_request/url_request_context_builder.cc#newcode204 net/url_request/url_request_context_builder.cc:204: network_session_params->host_mapping_rules = host_mapping_rules; On 2017/05/12 19:43:52, Randy Smith ...
3 years, 7 months ago (2017-05-12 20:13:17 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/453393)
3 years, 7 months ago (2017-05-12 22:37:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876243002/60001
3 years, 7 months ago (2017-05-12 23:22:29 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 00:11:28 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cfea205a4f3ebb3f443467fe96c7...

Powered by Google App Engine
This is Rietveld 408576698