Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 287623006: rebaseline_server: apply ignored-tests.txt within rebaseline_server, not just on the bots (Closed)

Created:
6 years, 7 months ago by epoger
Modified:
6 years, 7 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com, humper
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline_server: apply ignored-tests.txt within rebaseline_server, not just on the bots (SkipBuildbotRuns) BUG=skia:2514 NOTREECHECKS=True NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=14740

Patch Set 1 : add another failed test (NOT ignored--no code changes yet) #

Patch Set 2 : add ignored-tests.txt file, but code isn't reading it yet #

Patch Set 3 : make the code ignore those failures like it's supposed to #

Messages

Total messages: 5 (0 generated)
epoger
Ravi- PTAL. The code change itself is entirely within patchset 3; the earlier patches are ...
6 years, 7 months ago (2014-05-14 17:39:22 UTC) #1
rmistry
LGTM
6 years, 7 months ago (2014-05-14 18:02:09 UTC) #2
epoger
The CQ bit was checked by epoger@google.com
6 years, 7 months ago (2014-05-14 18:04:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/287623006/40001
6 years, 7 months ago (2014-05-14 18:04:34 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 18:04:50 UTC) #5
Message was sent while issue was closed.
Change committed as 14740

Powered by Google App Engine
This is Rietveld 408576698