Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: gm/rebaseline_server/results.py

Issue 287623006: rebaseline_server: apply ignored-tests.txt within rebaseline_server, not just on the bots (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: make the code ignore those failures like it's supposed to Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gm/rebaseline_server/results.py
diff --git a/gm/rebaseline_server/results.py b/gm/rebaseline_server/results.py
index 45ab1333c2f8ed433ef0c67c980db0d7e64ec27c..70b23425df934753553cce33c91ab9ccbdd306f2 100755
--- a/gm/rebaseline_server/results.py
+++ b/gm/rebaseline_server/results.py
@@ -246,6 +246,22 @@ class BaseComparisons(object):
return meta_dict
@staticmethod
+ def _read_noncomment_lines(path):
+ """Return a list of all noncomment lines within a file.
+
+ (A "noncomment" line is one that does not start with a '#'.)
+
+ Args:
+ path: path to file
+ """
+ lines = []
+ with open(path, 'r') as fh:
+ for line in fh:
+ if not line.startswith('#'):
+ lines.append(line.strip())
+ return lines
+
+ @staticmethod
def _create_relative_url(hashtype_and_digest, test_name):
"""Returns the URL for this image, relative to GM_ACTUALS_ROOT_HTTP_URL.

Powered by Google App Engine
This is Rietveld 408576698