Convert Vr tests to JUnit4

Convert Vr tests to JUnit4

patch from issue 2857583005 (http://crrev.com/2857583005)

Convert Vr tests in chrome_public_test_vr_apk to JUnit4. For more detail,
please check src/testing/android/docs/junit4.md

Also removes the image tests from VrShellTest.java since:
1. They provide no actual test coverage since Render Tests don't actually fail currently AND the way they captured screenshots is pretty much useless for VR (just captures a black screen)
2. The move to JUnit4 seems to have messed with them - each call to renderAndCompare was taking an absurd amount of time (30+ seconds each).

BUG=640116
Review-Url: https://codereview.chromium.org/2876223004
Cr-Commit-Position: refs/heads/master@{#471965}
Committed: https://chromium.googlesource.com/chromium/src/+/64baf01809ec9265017ce344d306497b2f855d38

[bsheedy, 2017-05-12 23:11:21]

Description was changed from

==========
Convert Vr tests to JUnit4

patch from issue 2857583005 at patchset 60001
(http://crrev.com/2857583005#ps60001)

Convert Vr tests in chrome_public_test_vr_apk to JUnit4. For more detail,
please check src/testing/android/docs/junit4.md

BUG=640116
==========

to

==========
Convert Vr tests to JUnit4

patch from issue 2857583005 (http://crrev.com/2857583005)

Convert Vr tests in chrome_public_test_vr_apk to JUnit4. For more detail,
please check src/testing/android/docs/junit4.md

Also removes the image tests from VrShellTest.java since:
1. They provide no actual test coverage since Render Tests don't actually fail
currently AND the way they captured screenshots is pretty much useless for VR
(just captures a black screen)
2. The move to JUnit4 seems to have messed with them - each call to
renderAndCompare was taking an absurd amount of time (30+ seconds each).

BUG=640116
==========

[bsheedy, 2017-05-12 23:26:30]

bsheedy@chromium.org changed reviewers:
+ dtrainor@chromium.org, jbudorick@chromium.org, mthiesse@chromium.org,
yolandyan@chromium.org

[bsheedy, 2017-05-12 23:26:31]

+all the people from the original CL by yolandyan@
(https://codereview.chromium.org/2857583005)

This is essentially the version of the tests from the last patch on that CL,
except:
1. No more null pointer exceptions from not calling
startMainActivityOnBlankPage() during setup
2. VrTestRule functions once again take WebContents references instead of
ChromeTabbedActivity (we need to be able to specify which WebContents to use for
some tests instead of always using the current active tab's)
3. Removal of several tests for reasons stated in the CL description

[the real yoland, 2017-05-15 16:02:01]

lgtm

[bsheedy, 2017-05-15 16:39:30]

The CQ bit was checked by bsheedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 16:40:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mthiesse, 2017-05-15 16:48:36]

lgtm

[commit-bot: I haz the power, 2017-05-15 17:31:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 17:31:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bsheedy, 2017-05-15 17:33:42]

The CQ bit was checked by bsheedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 17:34:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Trainor- moved to gerrit, 2017-05-15 17:55:54]

lgtm

[bsheedy, 2017-05-15 18:24:56]

The CQ bit was checked by bsheedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 18:25:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 19:29:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 19:29:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bsheedy, 2017-05-15 20:46:11]

The CQ bit was checked by bsheedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 20:47:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 22:00:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 22:00:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bsheedy, 2017-05-15 22:32:31]

The CQ bit was checked by bsheedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 22:34:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 00:54:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 00:54:22]

Dry run: This issue passed the CQ dry run.

[bsheedy, 2017-05-16 00:55:08]

The CQ bit was checked by bsheedy@chromium.org

[bsheedy, 2017-05-16 00:55:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, mthiesse@chromium.org, yolandyan@chromium.org
Link to the patchset: https://codereview.chromium.org/2876223004/#ps60001
(title: "Rebase again")

[commit-bot: I haz the power, 2017-05-16 00:56:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 01:12:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494896108714740,
"parent_rev": "18ea873dd28c6b2f49b529e57c55898f5df1b4d2", "commit_rev":
"64baf01809ec9265017ce344d306497b2f855d38"}

[commit-bot: I haz the power, 2017-05-16 01:12:49]

Description was changed from

==========
Convert Vr tests to JUnit4

patch from issue 2857583005 (http://crrev.com/2857583005)

Convert Vr tests in chrome_public_test_vr_apk to JUnit4. For more detail,
please check src/testing/android/docs/junit4.md

Also removes the image tests from VrShellTest.java since:
1. They provide no actual test coverage since Render Tests don't actually fail
currently AND the way they captured screenshots is pretty much useless for VR
(just captures a black screen)
2. The move to JUnit4 seems to have messed with them - each call to
renderAndCompare was taking an absurd amount of time (30+ seconds each).

BUG=640116
==========

to

==========
Convert Vr tests to JUnit4

patch from issue 2857583005 (http://crrev.com/2857583005)

Convert Vr tests in chrome_public_test_vr_apk to JUnit4. For more detail,
please check src/testing/android/docs/junit4.md

Also removes the image tests from VrShellTest.java since:
1. They provide no actual test coverage since Render Tests don't actually fail
currently AND the way they captured screenshots is pretty much useless for VR
(just captures a black screen)
2. The move to JUnit4 seems to have messed with them - each call to
renderAndCompare was taking an absurd amount of time (30+ seconds each).

BUG=640116

Review-Url: https://codereview.chromium.org/2876223004
Cr-Commit-Position: refs/heads/master@{#471965}
Committed:
https://chromium.googlesource.com/chromium/src/+/64baf01809ec9265017ce344d306...
==========

[commit-bot: I haz the power, 2017-05-16 01:12:50]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/64baf01809ec9265017ce344d306...